From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: lrg@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: tps62360: fix stylistic issue and optimize code
Date: Tue, 8 May 2012 12:46:56 +0100 [thread overview]
Message-ID: <20120508114655.GK15893@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1336476958-18620-1-git-send-email-ldewangan@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Tue, May 08, 2012 at 05:05:58PM +0530, Laxman Dewangan wrote:
> Fix multiple stylistic issue like:
> - The print message should be not break into multiple line.
> - line gap after variable declaration and statement.
> - checkpatch error.
> - some typo.
I've applied this but please in future always split changes into
separate patch rather than having a single jumbo change. There's
lots of different things here, things like the switch to using
gpio_request_one() should have been split out - this makes review
very much easier.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-08 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 11:35 [PATCH] regulator: tps62360: fix stylistic issue and optimize code Laxman Dewangan
2012-05-08 11:46 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508114655.GK15893@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.