From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Rhyland Klein <rklein@nvidia.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>, Liam Girdwood <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH 5/6 v3] mfd: tps65910-irq: Add devicetree init support
Date: Tue, 8 May 2012 17:29:02 +0100 [thread overview]
Message-ID: <20120508162901.GD15893@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1336504291.31930.24.camel@rklein-linux>
[-- Attachment #1: Type: text/plain, Size: 548 bytes --]
On Tue, May 08, 2012 at 12:11:31PM -0700, Rhyland Klein wrote:
> Is this more what you would expect? If the dt code initialized the
> irq_base to 0 instead of -1 then this should also work.
> pdata->irq_base = irq_alloc_descs(-1, pdata->irq_base,
> tps65910->irq_num, -1);
> if (pdata->irq_base <= 0) {
> dev_err(tps65910->dev, "Failed to allocate irq descs: %d\n",
> pdata->irq_base);
> return pdata->irq_base;
> }
More like:
if (pdata->irq_base)
base = pdata->irq_base;
else
base = 0;
pdata->irq_base = irq_alloc_descs(base, 0,
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-08 16:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 18:42 [PATCH 0/6 v3] Update TPS65910 to boot using devicetree Rhyland Klein
2012-05-08 18:42 ` Rhyland Klein
2012-05-08 16:48 ` Mark Brown
[not found] ` <1336502563-31789-1-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2012-05-08 18:42 ` [PATCH 1/6 v3] mfd: tps65910: Commonize regmap access through header Rhyland Klein
2012-05-08 18:42 ` Rhyland Klein
2012-05-08 18:42 ` [PATCH 2/6 v3] regulator: tps65910: Add device tree bindings Rhyland Klein
2012-05-08 18:42 ` Rhyland Klein
2012-05-08 18:42 ` [PATCH 3/6 v3] mfd: tps65910: Add device-tree support Rhyland Klein
2012-05-08 18:42 ` Rhyland Klein
2012-05-08 18:42 ` [PATCH 4/6 v3] regulator: tps65910 regulator: add device tree support Rhyland Klein
2012-05-08 18:42 ` Rhyland Klein
2012-05-12 10:19 ` Mark Brown
2012-05-08 18:42 ` [PATCH 5/6 v3] mfd: tps65910-irq: Add devicetree init support Rhyland Klein
2012-05-08 18:42 ` Rhyland Klein
2012-05-08 15:48 ` Mark Brown
2012-05-08 19:11 ` Rhyland Klein
2012-05-08 16:29 ` Mark Brown [this message]
2012-05-08 16:36 ` Rhyland Klein
2012-05-11 18:45 ` Grant Likely
2012-05-08 18:42 ` [PATCH 6/6 v3] ARM: Tegra: Add support for TPS65910 PMIC Rhyland Klein
2012-05-08 18:42 ` Rhyland Klein
2012-05-08 15:56 ` Stephen Warren
2012-05-08 15:58 ` Mark Brown
2012-05-08 16:15 ` Stephen Warren
2012-05-12 10:17 ` Mark Brown
2012-05-11 9:38 ` [PATCH 0/6 v3] Update TPS65910 to boot using devicetree Samuel Ortiz
2012-05-11 19:21 ` Rhyland Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508162901.GD15893@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=rklein@nvidia.com \
--cc=rob.herring@calxeda.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.