From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ola Lilja <ola.o.lilja@stericsson.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 09/11] ASoC: Ux500: Add platform-driver
Date: Tue, 8 May 2012 18:51:57 +0100 [thread overview]
Message-ID: <20120508175156.GI15893@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1336485444-27369-1-git-send-email-ola.o.lilja@stericsson.com>
[-- Attachment #1.1: Type: text/plain, Size: 439 bytes --]
On Tue, May 08, 2012 at 03:57:24PM +0200, Ola Lilja wrote:
> +int ux500_pcm_new(struct snd_soc_pcm_runtime *rtd)
> +{
> + struct snd_pcm *pcm = rtd->pcm;
> +
> + dev_dbg(rtd->platform->dev, "%s: Enter.\n", __func__);
> +
> + pcm->info_flags = 0;
> + strcpy(pcm->name, "UX500_PCM");
Hrm, this looks like the framework is missing something - you should
just be able to just configure this in your driver and have things
copied in for you.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-05-08 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 13:57 [PATCH 09/11] ASoC: Ux500: Add platform-driver Ola Lilja
2012-05-08 17:51 ` Mark Brown [this message]
2012-05-09 16:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508175156.GI15893@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linus.walleij@linaro.org \
--cc=lrg@ti.com \
--cc=ola.o.lilja@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.