From: "John W. Linville" <linville@tuxdriver.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Andrei Emeltchenko <andrei.emeltchenko.news@gmail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Remove compile warnings
Date: Tue, 8 May 2012 21:48:53 -0400 [thread overview]
Message-ID: <20120509014852.GA2533@tuxdriver.com> (raw)
In-Reply-To: <1336383024.4325.6.camel@jlt3.sipsolutions.net>
On Mon, May 07, 2012 at 11:30:24AM +0200, Johannes Berg wrote:
> On Fri, 2012-05-04 at 11:44 +0300, Andrei Emeltchenko wrote:
>
> > >> - case NL80211_IFTYPE_UNSPECIFIED:
> > >> - case NUM_NL80211_IFTYPES:
> > >> + default:
> > >
> > > When did this warning start occurring? I was pretty sure it didn't use
> > > to? I think we should explicitly list the cases here though because we
> > > want the compiler to warn here when we add something to the interface
> > > type list so we catch this place that may have to be modified.
> >
> > I think warning occurs when I added new interface type since it is
> > also not handled.
>
> Well, but in that case the warning is supposed to happen to tell you
> that you need to think about that code for your new interface type.
>
> John, please revert this patch.
I'm having to do some rebasing to handle the bluetooth kerfuffle.
I'll simply drop this patch.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
prev parent reply other threads:[~2012-05-09 2:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 12:45 [PATCH] cfg80211: Remove compile warnings Andrei Emeltchenko
2012-05-03 19:00 ` Johannes Berg
2012-05-04 8:44 ` Andrei Emeltchenko
2012-05-07 9:30 ` Johannes Berg
2012-05-09 1:48 ` John W. Linville [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509014852.GA2533@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.