From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Emmanuel Grumbach <egrumbach@gmail.com>
Cc: Wey-Yi Guy <wey-yi.w.guy@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Meenakshi Venkataraman <meenakshi.venkataraman@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 3.4] iwlwifi: fix a potential race in receive buffer allocation
Date: Wed, 9 May 2012 09:53:34 +0200 [thread overview]
Message-ID: <20120509075333.GA2363@redhat.com> (raw)
In-Reply-To: <CANUX_P3V6-sGO5+nmRA7b5wq-tDujs5gZtkrJQj_w29wD1tunQ@mail.gmail.com>
On Tue, May 08, 2012 at 08:00:29PM +0300, Emmanuel Grumbach wrote:
> >
> > This patch make no sense. Nothing stops compiler or CPU to write
> > ->page into memory before ->page_dma .
> >
>
> I thought that too,but the call to dma_map... is a call to functon.
> Shouldn't force the compiler the make things in order. Or maybe the
> assignment to rxb->page_dma can be reordered... I am not really sure.
Calling a non lock/unlock function does not make any guarantees about
ordering.
Stanislaw
prev parent reply other threads:[~2012-05-09 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 21:09 [PATCH 3.4] iwlwifi: fix a potential race in receive buffer allocation Wey-Yi Guy
2012-05-08 14:05 ` Stanislaw Gruszka
2012-05-08 17:00 ` Emmanuel Grumbach
2012-05-08 18:34 ` Venkataraman, Meenakshi
2012-05-09 7:53 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509075333.GA2363@redhat.com \
--to=sgruszka@redhat.com \
--cc=egrumbach@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meenakshi.venkataraman@intel.com \
--cc=stable@vger.kernel.org \
--cc=wey-yi.w.guy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.