Re: [PATCH 3/3] Bluetooth: Remove batostr()

[Gustavo Padovan <gustavo@padovan.org>]

Hi Ulisses,

* Ulisses Furquim <ulisses@profusion.mobi> [2012-05-09 08:17:59 -0300]:

> Hi Andrei,
>=20
> On Wed, May 9, 2012 at 6:02 AM, Andrei Emeltchenko
> <andrei.emeltchenko.news@gmail.com> wrote:
> > Hi Ulisses,
> >
> > On Tue, May 08, 2012 at 03:11:01PM -0300, Ulisses Furquim wrote:
> >> >> > batostr() is not used anywhere and I don't see any reason why we =
should
> >> >> > keep it. Use ba2str() instead.
> >> >> >
> >> >> > Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> >> >> > ---
> >> >> > =A0include/net/bluetooth/bluetooth.h | =A0 =A01 -
> >> >> > =A0net/bluetooth/lib.c =A0 =A0 =A0 =A0 =A0 =A0 =A0 | =A0 14 -----=
---------
> >> >> > =A02 files changed, 15 deletions(-)
> >> >>
> >> >> The patchset looks good to me. I'm also not sure we need another
> >> >> specifier for snprintf().
> >> >>
> >> >> Given we had static buffers instead of allocating them in the stack
> >> >> every time it'd be good to hear from Marcel if we had a reason and =
if
> >> >> it's still valid. IMO we don't have problems with stack usage in our
> >> >> code paths now but I haven't actually checked it.
> >> >
> >> > that code is most likely 11+ years old. It is actually not from me. =
So
> >> > if you wanna know why, you need to track down Max.
> >> >
> >> > Using %pM and baswap seems to be the best approach for fixing this r=
ight
> >> > now. However I am not against introducing a snprintf modifier for
> >> > Bluetooth addresses.
> >>
> >> I see. Ok, makes sense. David or Andrei? Will any of you guys send a p=
atch?
> >
> > I think that adding print specifier is the best option, we can apply old
> > patch from Joe Perches.
>=20
> Indeed. I've just seen his e-mail and patch. I just don't understand
> why we haven't merged it before.

That patch should go through other maintainer since it touches lib/vsprintf=
=2Ec.
That maybe the reason it is not merged yet.

	Gustavo