From: Tony Lindgren <tony@atomide.com>
To: Enrico Butera <ebutera@users.sourceforge.net>
Cc: linux-omap@vger.kernel.org, Olof Johansson <olof@lixom.net>,
Enrico Butera <ebutera@users.berlios.de>
Subject: Re: [PATCH v2] OMAP: igep0020: fix smsc911x dummy regulator id
Date: Wed, 9 May 2012 08:23:59 -0700 [thread overview]
Message-ID: <20120509152358.GH5088@atomide.com> (raw)
In-Reply-To: <1336555679-15676-1-git-send-email-ebutera@users.sourceforge.net>
* Enrico Butera <ebutera@users.sourceforge.net> [120509 02:32]:
> From: Enrico Butera <ebutera@users.berlios.de>
>
> id 0 is already used and causes errors at boot:
>
> WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
> sysfs: cannot create duplicate filename '/devices/platform/reg-fixed-voltage.0'
>
> Fix it by using the next available one (id=1).
Thanks adding into fixes with updated comments for the regression,
updated patch below.
Tony
From: Enrico Butera <ebutera@users.berlios.de>
Date: Wed, 9 May 2012 11:27:59 +0200
Subject: [PATCH] ARM: OMAP: igep0020: fix smsc911x dummy regulator id
id 0 is already used and causes errors at boot:
WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
sysfs: cannot create duplicate filename '/devices/platform/reg-fixed-voltage.0'
Fix it by using the next available one (id=1).
This was caused by 5b3689f4 (ARM: OMAP2+: smsc911x: Add fixed
board regulators) that did not account for some regulators
already being used.
Signed-off-by: Enrico Butera <ebutera@users.berlios.de>
[tony@atomide.com: updated comments for regression causing commit]
Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
index 930c0d3..740cee9 100644
--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -641,7 +641,7 @@ static struct regulator_consumer_supply dummy_supplies[] = {
static void __init igep_init(void)
{
- regulator_register_fixed(0, dummy_supplies, ARRAY_SIZE(dummy_supplies));
+ regulator_register_fixed(1, dummy_supplies, ARRAY_SIZE(dummy_supplies));
omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
/* Get IGEP2 hardware revision */
prev parent reply other threads:[~2012-05-09 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 9:27 [PATCH v2] OMAP: igep0020: fix smsc911x dummy regulator id Enrico Butera
2012-05-09 15:23 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120509152358.GH5088@atomide.com \
--to=tony@atomide.com \
--cc=ebutera@users.berlios.de \
--cc=ebutera@users.sourceforge.net \
--cc=linux-omap@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.