Re: [PATCH] video: s3c-fb: s3c_fb_missing_pixclock() can't be __devinit

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

On Thu, May 10, 2012 at 12:10:13AM +0000, Florian Tobias Schandinat wrote:
> On 04/15/2012 10:39 AM, Mark Brown wrote:
> > Since s3c_fb_missing_pixclock() is called from s3c_fb_set_rgb_timing()
> > which is used in the suspend/resume paths it can't be marked __devinit
> > as this could result in it being discarded after boot.

> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

> I'm not sure that this can actually happen. But the code looks saner
> with the patch applied so I applied it.

Thanks.  To trigger you'd need to disable CONFIG_HOTPLUG and modules
(possibly some other stuff too) but the main motiviation is that the
build system complains loudly about section mismatches.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]