From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH] spi/topcliff: use correct __devexit_p annotation Date: Wed, 09 May 2012 18:25:05 -0600 Message-ID: <20120510002505.172243E08F4@localhost> References: <1336602923-5724-1-git-send-email-mathieu.poirier@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org To: mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Return-path: In-Reply-To: <1336602923-5724-1-git-send-email-mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Wed, 9 May 2012 16:35:23 -0600, mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org wrote: > From: Arnd Bergmann > > __devexit functions are discarded when CONFIG_HOTPLUG > is not set, so the symbol needs to be referenced carefully. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Mathieu Poirier Applied, thanks. g. > --- > drivers/spi/spi-topcliff-pch.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c > index ec47d3b..77c4562 100644 > --- a/drivers/spi/spi-topcliff-pch.c > +++ b/drivers/spi/spi-topcliff-pch.c > @@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = { > .name = "pch_spi", > .id_table = pch_spi_pcidev_id, > .probe = pch_spi_probe, > - .remove = pch_spi_remove, > + .remove = __devexit_p(pch_spi_remove), > .suspend = pch_spi_suspend, > .resume = pch_spi_resume, > }; > -- > 1.7.5.4 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761463Ab2EJAZK (ORCPT ); Wed, 9 May 2012 20:25:10 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:34950 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877Ab2EJAZI (ORCPT ); Wed, 9 May 2012 20:25:08 -0400 From: Grant Likely Subject: Re: [PATCH] spi/topcliff: use correct __devexit_p annotation To: mathieu.poirier@linaro.org Cc: spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, arnd@arndb.de, mathieu.poirier@linaro.org In-Reply-To: <1336602923-5724-1-git-send-email-mathieu.poirier@linaro.org> References: <1336602923-5724-1-git-send-email-mathieu.poirier@linaro.org> Date: Wed, 09 May 2012 18:25:05 -0600 Message-Id: <20120510002505.172243E08F4@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 May 2012 16:35:23 -0600, mathieu.poirier@linaro.org wrote: > From: Arnd Bergmann > > __devexit functions are discarded when CONFIG_HOTPLUG > is not set, so the symbol needs to be referenced carefully. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Mathieu Poirier Applied, thanks. g. > --- > drivers/spi/spi-topcliff-pch.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/spi/spi-topcliff-pch.c b/drivers/spi/spi-topcliff-pch.c > index ec47d3b..77c4562 100644 > --- a/drivers/spi/spi-topcliff-pch.c > +++ b/drivers/spi/spi-topcliff-pch.c > @@ -1779,7 +1779,7 @@ static struct pci_driver pch_spi_pcidev_driver = { > .name = "pch_spi", > .id_table = pch_spi_pcidev_id, > .probe = pch_spi_probe, > - .remove = pch_spi_remove, > + .remove = __devexit_p(pch_spi_remove), > .suspend = pch_spi_suspend, > .resume = pch_spi_resume, > }; > -- > 1.7.5.4 > -- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.