From: Evgeniy Polyakov <zbr@ioremap.net>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: Alban Crequy <alban.crequy@collabora.co.uk>,
netdev@vger.kernel.org,
Vincent Sanders <vincent.sanders@collabora.co.uk>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Rodrigo Moya <rodrigo.moya@collabora.co.uk>
Subject: Re: [PATCH] netlink: connector: implement cn_netlink_reply
Date: Thu, 10 May 2012 04:45:53 +0400 [thread overview]
Message-ID: <20120510004553.GB8362@ioremap.net> (raw)
In-Reply-To: <1336609248.2499.20.camel@bwh-desktop.uk.solarflarecom.com>
On Thu, May 10, 2012 at 01:20:48AM +0100, Ben Hutchings (bhutchings@solarflare.com) wrote:
> On Wed, 2012-05-09 at 15:37 +0100, Alban Crequy wrote:
> > In a connector callback, it was not possible to reply to a message only to a
> > sender. This patch implements cn_netlink_reply(). It uses the connector socket
> > to send an unicast netlink message back to the sender.
> [...]
>
> We try to avoid adding functions with no users. You'll need to submit
> the code that's intended to use this as well.
I have no objection against this patch, but as correctly stated it is
useless without users. Alban, what is the code you want this
functionality to be used in? Do you plan to submit it? Can you submit
this change in the patch with your code?
--
Evgeniy Polyakov
next prev parent reply other threads:[~2012-05-10 0:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 14:37 [PATCH] netlink: connector: implement cn_netlink_reply Alban Crequy
2012-05-10 0:20 ` Ben Hutchings
2012-05-10 0:45 ` Evgeniy Polyakov [this message]
2012-05-10 10:39 ` Alban Crequy
2012-05-10 16:47 ` Evgeniy Polyakov
2012-05-10 19:22 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510004553.GB8362@ioremap.net \
--to=zbr@ioremap.net \
--cc=alban.crequy@collabora.co.uk \
--cc=bhutchings@solarflare.com \
--cc=javier.martinez@collabora.co.uk \
--cc=netdev@vger.kernel.org \
--cc=rodrigo.moya@collabora.co.uk \
--cc=vincent.sanders@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.