From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 10 May 2012 07:33:02 +0000 Subject: [patch] gma500: silence an unused variable warning Message-Id: <20120510073302.GA5919@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: David Airlie Cc: Dave Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, "Kirill A. Shutemov" , Alan Cox If CONFIG_BACKLIGHT_CLASS_DEVICE is disabled then GCC warns that: drivers/gpu/drm/gma500/opregion.c:154:6: warning: unused variable ‘max’ [-Wunused-variable] Which give me a chance to use the new config_enabled() macro. :) Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/gma500/opregion.c b/drivers/gpu/drm/gma500/opregion.c index 05661bf..d2125ba 100644 --- a/drivers/gpu/drm/gma500/opregion.c +++ b/drivers/gpu/drm/gma500/opregion.c @@ -151,7 +151,6 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp) struct drm_psb_private *dev_priv = dev->dev_private; struct opregion_asle *asle = dev_priv->opregion.asle; struct backlight_device *bd = dev_priv->backlight_device; - u32 max; DRM_DEBUG_DRIVER("asle set backlight %x\n", bclp); @@ -165,11 +164,12 @@ static u32 asle_set_backlight(struct drm_device *dev, u32 bclp) if (bclp > 255) return ASLE_BACKLIGHT_FAILED; -#ifdef CONFIG_BACKLIGHT_CLASS_DEVICE - max = bd->props.max_brightness; - bd->props.brightness = bclp * max / 255; - backlight_update_status(bd); -#endif + if (config_enabled(CONFIG_BACKLIGHT_CLASS_DEVICE)) { + int max = bd->props.max_brightness; + bd->props.brightness = bclp * max / 255; + backlight_update_status(bd); + } + asle->cblv = (bclp * 0x64) / 0xff | ASLE_CBLV_VALID; return 0; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] gma500: silence an unused variable warning Date: Thu, 10 May 2012 10:33:02 +0300 Message-ID: <20120510073302.GA5919@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by gabe.freedesktop.org (Postfix) with ESMTP id 033699E9F3 for ; Thu, 10 May 2012 00:33:16 -0700 (PDT) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: David Airlie Cc: Dave Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, "Kirill A. Shutemov" , Alan Cox List-Id: dri-devel@lists.freedesktop.org SWYgQ09ORklHX0JBQ0tMSUdIVF9DTEFTU19ERVZJQ0UgaXMgZGlzYWJsZWQgdGhlbiBHQ0Mgd2Fy bnMgdGhhdDoKCWRyaXZlcnMvZ3B1L2RybS9nbWE1MDAvb3ByZWdpb24uYzoxNTQ6Njogd2Fybmlu ZzoKCQl1bnVzZWQgdmFyaWFibGUg4oCYbWF44oCZIFstV3VudXNlZC12YXJpYWJsZV0KCldoaWNo IGdpdmUgbWUgYSBjaGFuY2UgdG8gdXNlIHRoZSBuZXcgY29uZmlnX2VuYWJsZWQoKSBtYWNyby4g IDopCgpTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5j b20+CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2dtYTUwMC9vcHJlZ2lvbi5jIGIvZHJp dmVycy9ncHUvZHJtL2dtYTUwMC9vcHJlZ2lvbi5jCmluZGV4IDA1NjYxYmYuLmQyMTI1YmEgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9nbWE1MDAvb3ByZWdpb24uYworKysgYi9kcml2ZXJz L2dwdS9kcm0vZ21hNTAwL29wcmVnaW9uLmMKQEAgLTE1MSw3ICsxNTEsNiBAQCBzdGF0aWMgdTMy IGFzbGVfc2V0X2JhY2tsaWdodChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1MzIgYmNscCkKIAlz dHJ1Y3QgZHJtX3BzYl9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7CiAJc3Ry dWN0IG9wcmVnaW9uX2FzbGUgKmFzbGUgPSBkZXZfcHJpdi0+b3ByZWdpb24uYXNsZTsKIAlzdHJ1 Y3QgYmFja2xpZ2h0X2RldmljZSAqYmQgPSBkZXZfcHJpdi0+YmFja2xpZ2h0X2RldmljZTsKLQl1 MzIgbWF4OwogCiAJRFJNX0RFQlVHX0RSSVZFUigiYXNsZSBzZXQgYmFja2xpZ2h0ICV4XG4iLCBi Y2xwKTsKIApAQCAtMTY1LDExICsxNjQsMTIgQEAgc3RhdGljIHUzMiBhc2xlX3NldF9iYWNrbGln aHQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdTMyIGJjbHApCiAJaWYgKGJjbHAgPiAyNTUpCiAJ CXJldHVybiBBU0xFX0JBQ0tMSUdIVF9GQUlMRUQ7CiAKLSNpZmRlZiBDT05GSUdfQkFDS0xJR0hU X0NMQVNTX0RFVklDRQotCW1heCA9IGJkLT5wcm9wcy5tYXhfYnJpZ2h0bmVzczsKLQliZC0+cHJv cHMuYnJpZ2h0bmVzcyA9IGJjbHAgKiBtYXggLyAyNTU7Ci0JYmFja2xpZ2h0X3VwZGF0ZV9zdGF0 dXMoYmQpOwotI2VuZGlmCisJaWYgKGNvbmZpZ19lbmFibGVkKENPTkZJR19CQUNLTElHSFRfQ0xB U1NfREVWSUNFKSkgeworCQlpbnQgbWF4ID0gYmQtPnByb3BzLm1heF9icmlnaHRuZXNzOworCQli ZC0+cHJvcHMuYnJpZ2h0bmVzcyA9IGJjbHAgKiBtYXggLyAyNTU7CisJCWJhY2tsaWdodF91cGRh dGVfc3RhdHVzKGJkKTsKKwl9CisKIAlhc2xlLT5jYmx2ID0gKGJjbHAgKiAweDY0KSAvIDB4ZmYg fCBBU0xFX0NCTFZfVkFMSUQ7CiAKIAlyZXR1cm4gMDsKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9kcmktZGV2ZWwK