diff for duplicates of <20120510093442.GK3908@opensource.wolfsonmicro.com> diff --git a/a/1.txt b/N1/1.txt index c65a14b..915914e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,8 +2,8 @@ On Thu, May 10, 2012 at 12:54:24PM +0530, Yadwinder Singh Brar wrote: > On Thu, May 10, 2012 at 12:17 AM, Mark Brown > > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote: -> >> + [MAX77686_EN32KHZ_AP] = NULL, -> >> + [MAX77686_EN32KHZ_CP] = NULL, +> >> + ? ? [MAX77686_EN32KHZ_AP] = NULL, +> >> + ? ? [MAX77686_EN32KHZ_CP] = NULL, > > Now that the generic clock API is in mainline these should be moved over > > to use it. @@ -13,10 +13,10 @@ On Thu, May 10, 2012 at 12:54:24PM +0530, Yadwinder Singh Brar wrote: These are not regulators, these are clocks. They should use the clock API. -> >> + if (pdata->ramp_delay) { -> >> + max77686->ramp_delay = pdata->ramp_delay; -> >> + max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1, -> >> + RAMP_VALUE, RAMP_MASK); +> >> + ? ? if (pdata->ramp_delay) { +> >> + ? ? ? ? ? ? max77686->ramp_delay = pdata->ramp_delay; +> >> + ? ? ? ? ? ? max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1, +> >> + ? ? ? ? ? ? ? ? ? ? RAMP_VALUE, RAMP_MASK); > > This appears not to actually use the value passed in as platform_data. @@ -26,3 +26,10 @@ API. Why is the driver unconditionally writing these register values here rather than setting the ramp delay that was passed in? +-------------- next part -------------- +A non-text attachment was scrubbed... +Name: signature.asc +Type: application/pgp-signature +Size: 836 bytes +Desc: Digital signature +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120510/52a8cef0/attachment-0001.sig> diff --git a/a/2.bin b/a/2.bin deleted file mode 100644 index 144b3a6..0000000 --- a/a/2.bin +++ /dev/null @@ -1,17 +0,0 @@ ------BEGIN PGP SIGNATURE----- -Version: GnuPG v1.4.12 (GNU/Linux) - -iQIcBAEBAgAGBQJPq4urAAoJEBus8iNuMP3dm4MP/2/+jQIWB2OMph66lu7FnD0s -gc/YAQCsinMwiKpRTRNkYJNzGc+IRZyHelqLTc8cRXgdLtsZDrWdBVaxqXbiftIz -57jEz3Tr+5ovgIjllJ7a65J/Ye2a3VdozyPqxTqfISK45piHCy2NGTJIctbCqfDA -JYpV/Vhqn/Lb3fg2xquGtCh6Hd9omD7TYhqdTpPNUzMIkj3xrEiX5Iv1zpBMMpst -u/rLyEHTUj7tovJkOrtkLUVe5PFm6M07g7KgvaaUC52+bjdh1t+slMSYgaL4zw17 -760CG4NO/3xxoxNDDH7wb6uJ+BA/mMyhU/ay4tJVZlMbOJQ14V327+R4F/QEm3NC -SDQJDKAGb+IdoYcQPxtCMWia5NzU+l4a62pHvByelFBMnZUJhyRJHibvwdmK5XUU -VAtdwPY6/X3jmeMGSnT4E1iQMDFFqA8ghi+bByL4ROqt1Bl9WqrbecTEPOaSakIm -GwiMdfqoKd4Mwwl+y83M1iRgp2Xvc+exe0ZNnvxOWJFwzFzpouB/2e9TxQ0MfVN6 -IimTEk851eJHJTslsnQUZRe155QChIYuDqcmZy3ufaXePoOHNGxJrRcLeTdZCfHa -eVMvFbVdWk8+ugYFNxdc54Gf4NQxkTB7M5NuebfJufUPvAwH0DiRbAwsOzh3z+3L -zIgSXcgj+zPdFcZ9RLU2 -=W6IA ------END PGP SIGNATURE----- diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index 3237378..0000000 --- a/a/2.hdr +++ /dev/null @@ -1,2 +0,0 @@ -Content-Type: application/pgp-signature; name="signature.asc" -Content-Description: Digital signature diff --git a/a/content_digest b/N1/content_digest index b2b4936..9cee14d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,22 +2,18 @@ "ref\01336580695-1184-3-git-send-email-yadi.brar@samsung.com\0" "ref\020120509184709.GC32037@sirena.org.uk\0" "ref\0CAKew6eWEYBP1zXXwLL4eWOhOKZ-HwAfUX_kg8cnsaDyUXVKSkQ@mail.gmail.com\0" - "From\0Mark Brown <broonie@opensource.wolfsonmicro.com>\0" - "Subject\0Re: [PATCH 2/2] regulator: Add support for MAX77686.\0" + "From\0broonie@opensource.wolfsonmicro.com (Mark Brown)\0" + "Subject\0[PATCH 2/2] regulator: Add support for MAX77686.\0" "Date\0Thu, 10 May 2012 10:34:43 +0100\0" - "To\0Yadwinder Singh Brar <yadi.brar01@gmail.com>\0" - "Cc\0Yadwinder Singh <yadi.brar@samsung.com>" - linux-samsung-soc@vger.kernel.org - linux-kernel@vger.kernel.org - " linux-arm-kernel@lists.infradead.org\0" - "\01:1\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "\00:1\0" "b\0" "On Thu, May 10, 2012 at 12:54:24PM +0530, Yadwinder Singh Brar wrote:\n" "> On Thu, May 10, 2012 at 12:17 AM, Mark Brown\n" "> > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote:\n" "\n" - "> >> + \302\240 \302\240 [MAX77686_EN32KHZ_AP] = NULL,\n" - "> >> + \302\240 \302\240 [MAX77686_EN32KHZ_CP] = NULL,\n" + "> >> + ? ? [MAX77686_EN32KHZ_AP] = NULL,\n" + "> >> + ? ? [MAX77686_EN32KHZ_CP] = NULL,\n" "\n" "> > Now that the generic clock API is in mainline these should be moved over\n" "> > to use it.\n" @@ -27,10 +23,10 @@ "These are not regulators, these are clocks. They should use the clock\n" "API.\n" "\n" - "> >> + \302\240 \302\240 if (pdata->ramp_delay) {\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 max77686->ramp_delay = pdata->ramp_delay;\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1,\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 RAMP_VALUE, RAMP_MASK);\n" + "> >> + ? ? if (pdata->ramp_delay) {\n" + "> >> + ? ? ? ? ? ? max77686->ramp_delay = pdata->ramp_delay;\n" + "> >> + ? ? ? ? ? ? max77686_update_reg(i2c, MAX77686_REG_BUCK2CTRL1,\n" + "> >> + ? ? ? ? ? ? ? ? ? ? RAMP_VALUE, RAMP_MASK);\n" "\n" "> > This appears not to actually use the value passed in as platform_data.\n" "\n" @@ -39,27 +35,13 @@ "> ramp_rate control bits of control registers.\n" "\n" "Why is the driver unconditionally writing these register values here\n" - rather than setting the ramp delay that was passed in? - "\01:2\0" - "fn\0signature.asc\0" - "d\0Digital signature\0" - "b\0" - "-----BEGIN PGP SIGNATURE-----\n" - "Version: GnuPG v1.4.12 (GNU/Linux)\n" - "\n" - "iQIcBAEBAgAGBQJPq4urAAoJEBus8iNuMP3dm4MP/2/+jQIWB2OMph66lu7FnD0s\n" - "gc/YAQCsinMwiKpRTRNkYJNzGc+IRZyHelqLTc8cRXgdLtsZDrWdBVaxqXbiftIz\n" - "57jEz3Tr+5ovgIjllJ7a65J/Ye2a3VdozyPqxTqfISK45piHCy2NGTJIctbCqfDA\n" - "JYpV/Vhqn/Lb3fg2xquGtCh6Hd9omD7TYhqdTpPNUzMIkj3xrEiX5Iv1zpBMMpst\n" - "u/rLyEHTUj7tovJkOrtkLUVe5PFm6M07g7KgvaaUC52+bjdh1t+slMSYgaL4zw17\n" - "760CG4NO/3xxoxNDDH7wb6uJ+BA/mMyhU/ay4tJVZlMbOJQ14V327+R4F/QEm3NC\n" - "SDQJDKAGb+IdoYcQPxtCMWia5NzU+l4a62pHvByelFBMnZUJhyRJHibvwdmK5XUU\n" - "VAtdwPY6/X3jmeMGSnT4E1iQMDFFqA8ghi+bByL4ROqt1Bl9WqrbecTEPOaSakIm\n" - "GwiMdfqoKd4Mwwl+y83M1iRgp2Xvc+exe0ZNnvxOWJFwzFzpouB/2e9TxQ0MfVN6\n" - "IimTEk851eJHJTslsnQUZRe155QChIYuDqcmZy3ufaXePoOHNGxJrRcLeTdZCfHa\n" - "eVMvFbVdWk8+ugYFNxdc54Gf4NQxkTB7M5NuebfJufUPvAwH0DiRbAwsOzh3z+3L\n" - "zIgSXcgj+zPdFcZ9RLU2\n" - "=W6IA\n" - "-----END PGP SIGNATURE-----\n" + "rather than setting the ramp delay that was passed in?\n" + "-------------- next part --------------\n" + "A non-text attachment was scrubbed...\n" + "Name: signature.asc\n" + "Type: application/pgp-signature\n" + "Size: 836 bytes\n" + "Desc: Digital signature\n" + URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120510/52a8cef0/attachment-0001.sig> -40a5f081e17eed54206febccb1d82b79a3ea509bd76ca46490f5492b5e956380 +97de72b6cda09f87aaee90aba6468f71d609f74564bbba98cd123a31c6f482e0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.