From: Johan Hovold <jhovold@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: lm3533-core: Fix calling regmap_update_bits() with mask and val arguments swapped
Date: Thu, 10 May 2012 17:49:25 +0200 [thread overview]
Message-ID: <20120510154925.GB29437@localhost> (raw)
In-Reply-To: <1336664102.15392.1.camel@phoenix>
On Thu, May 10, 2012 at 11:35:02PM +0800, Axel Lin wrote:
> Current code calls regmap_update_bits() with mask and val arguments swapped.
> Fix it.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
> ---
Ouch, I was sure I'd fixed that in the submitted v2.
/Johan
> drivers/mfd/lm3533-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 75f4b7f..4a006c2 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -128,7 +128,7 @@ int lm3533_update(struct lm3533 *lm3533, u8 reg, u8 val, u8 mask)
>
> dev_dbg(lm3533->dev, "update [%02x]: %02x/%02x\n", reg, val, mask);
>
> - ret = regmap_update_bits(lm3533->regmap, reg, val, mask);
> + ret = regmap_update_bits(lm3533->regmap, reg, mask, val);
> if (ret < 0) {
> dev_err(lm3533->dev, "failed to update register %02x: %d\n",
> reg, ret);
next prev parent reply other threads:[~2012-05-10 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 15:35 [PATCH] mfd: lm3533-core: Fix calling regmap_update_bits() with mask and val arguments swapped Axel Lin
2012-05-10 15:49 ` Johan Hovold [this message]
2012-05-11 13:36 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510154925.GB29437@localhost \
--to=jhovold@gmail.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.