All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: linux-wireless@vger.kernel.org,
	florian.c.schilhabel@googlemail.com, ali@internetdog.org,
	netdev@vger.kernel.org, Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 0/3] staging: delete duplicated files/functionality in rtl8712
Date: Thu, 10 May 2012 09:54:51 -0700	[thread overview]
Message-ID: <20120510165451.GA12958@kroah.com> (raw)
In-Reply-To: <1336621641-15467-1-git-send-email-paul.gortmaker@windriver.com>

On Wed, May 09, 2012 at 11:47:18PM -0400, Paul Gortmaker wrote:
> A git grep happened to lead me into this dir, and once there I couldn't
> simply leave and pretend I didn't see the stuff that I saw.
> 
> There were duplicated basic networking headers like if_ether.h and
> ip.h (of course, some ancient versions, too).  And a whole whack of
> boilerplate endian handling functionality duplicated too.
> 
> I forced myself to stop looking after that.

Yes, it's a mess, thanks for working on cleaning it up, even a little
bit, it all helps.

> Anyway, a trivial redirection onto mainline's networking headers
> in the proper include dir, and a deletion of any references to
> the endian headers and the thing still happily builds on x86_64
> and ppc even after shitcanning seven useless files.
> 
> These three commits are against May 8th's linux-next tree.  I've
> used "-D" to hide the line-by-line content of the deletions.

Can you regenerate these with the full deletion content?  There have
been some spelling fixes in these files, and your patches do not apply
due to them.  I can hand-edit the patches if you regenerate it.

Or if you rebase on the last linux-next tree, that will pick those
changes up and then I can apply these properly.

thanks,

greg k-h

  parent reply	other threads:[~2012-05-10 16:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10  3:47 [PATCH 0/3] staging: delete duplicated files/functionality in rtl8712 Paul Gortmaker
2012-05-10  3:47 ` Paul Gortmaker
2012-05-10  3:47 ` [PATCH 1/3] staging: wean rtl8712 off of its ancient duplicate of if_ether.h Paul Gortmaker
2012-05-10  3:47 ` [PATCH 2/3] staging: wean rtl8712 off of its ancient duplicate of ip.h Paul Gortmaker
2012-05-10  3:47 ` [PATCH 3/3] staging: delete all duplicated endian crap from rtl8712 driver Paul Gortmaker
2012-05-10 16:54 ` Greg Kroah-Hartman [this message]
2012-05-10 17:31   ` [PATCH 0/3] staging: delete duplicated files/functionality in rtl8712 Paul Gortmaker
2012-05-10 17:31     ` Paul Gortmaker
2012-05-10 18:11     ` Greg Kroah-Hartman
2012-05-10 18:11       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120510165451.GA12958@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=ali@internetdog.org \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.