From: Grant Likely <grant.likely@secretlab.ca>
To: Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linus.walleij@stericsson.com,
Julia Lawall <Julia.Lawall@lip6.fr>
Subject: Re: [PATCH] gpio/langwell: re-read the IRQ status register after each iteration
Date: Thu, 10 May 2012 16:35:54 -0600 [thread overview]
Message-ID: <20120510223554.183F83E04A6@localhost> (raw)
In-Reply-To: <CACRpkdbA58UiNLZRPWe1yGckGFrXqtJ3ddqjLLzLntC6+Cin3g@mail.gmail.com>
On Thu, 10 May 2012 14:16:56 +0200, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, May 10, 2012 at 12:01 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
>
> > Spotted by Grant Likely. The IRQ status register should be re-read after
> > each iteration. Otherwise the loop misses the interrupt if it gets raised
> > immediately after handled.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
> > This patch applies on top of my previous patch ("gpio: langwell: convert to
> > use irq_domain").
>
> Oh yeah that thing I recognize!
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thanks.
g.
prev parent reply other threads:[~2012-05-10 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 10:01 [PATCH] gpio/langwell: re-read the IRQ status register after each iteration Mika Westerberg
2012-05-10 12:16 ` Linus Walleij
2012-05-10 20:34 ` Julia Lawall
2012-05-11 11:57 ` Linus Walleij
2012-05-10 22:35 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120510223554.183F83E04A6@localhost \
--to=grant.likely@secretlab.ca \
--cc=Julia.Lawall@lip6.fr \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.