From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grant Likely Subject: Re: [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated Date: Thu, 10 May 2012 21:24:55 -0600 Message-ID: <20120511032455.6BB853E04A6@localhost> References: <1336657841-2306-1-git-send-email-shubhrajyoti@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, andrew-g2DYL2Zd6BY@public.gmane.org To: Linus Walleij , Shubhrajyoti D Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thu, 10 May 2012 16:01:27 +0200, Linus Walleij wrote: > On Thu, May 10, 2012 at 3:50 PM, Shubhrajyoti D wrote: > > > Currently the prepare/unprepare transfer are called unconditionally. > > The assumption is that every driver using the spi core queue infrastructure > > has to populate the prepare and unprepare functions. This encourages > > drivers to populate empty functions to prevent crashing. > > This patch prevents the call to prepare/unprepare if not populated. > > > > Cc: Linus Walleij > > Signed-off-by: Shubhrajyoti D > > Great! > Acked-by: Linus Walleij Applied, thanks (after fixing extra whitespace defect). g. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932916Ab2EKD2u (ORCPT ); Thu, 10 May 2012 23:28:50 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:44234 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932255Ab2EKD2s (ORCPT ); Thu, 10 May 2012 23:28:48 -0400 From: Grant Likely Subject: Re: [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated To: Linus Walleij , Shubhrajyoti D Cc: spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, andrew@lunn.ch In-Reply-To: References: <1336657841-2306-1-git-send-email-shubhrajyoti@ti.com> Date: Thu, 10 May 2012 21:24:55 -0600 Message-Id: <20120511032455.6BB853E04A6@localhost> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 May 2012 16:01:27 +0200, Linus Walleij wrote: > On Thu, May 10, 2012 at 3:50 PM, Shubhrajyoti D wrote: > > > Currently the prepare/unprepare transfer are called unconditionally. > > The assumption is that every driver using the spi core queue infrastructure > > has to populate the prepare and unprepare functions. This encourages > > drivers to populate empty functions to prevent crashing. > > This patch prevents the call to prepare/unprepare if not populated. > > > > Cc: Linus Walleij > > Signed-off-by: Shubhrajyoti D > > Great! > Acked-by: Linus Walleij Applied, thanks (after fixing extra whitespace defect). g.