All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Holt <holt@sgi.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>, Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Commit cb83b62 fails to boot with a divide by zero error.
Date: Fri, 11 May 2012 08:39:38 -0500	[thread overview]
Message-ID: <20120511133938.GG3751@sgi.com> (raw)

Ingo, there is a breakage in the x86/master branch.

While testing some of our configurations, we found they would not boot.
The following got things working:

--- linux.orig/kernel/sched/fair.c      2012-05-11 06:29:44.000000000 -0500
+++ linux/kernel/sched/fair.c   2012-05-11 06:31:52.217156410 -0500
@@ -3835,7 +3835,7 @@ static inline void update_sg_lb_stats(st
        }
 
        /* Adjust by relative CPU power of the group */
-       sgs->avg_load = (sgs->group_load*SCHED_POWER_SCALE) / group->sgp->power;
+       sgs->avg_load = (sgs->group_load*SCHED_POWER_SCALE) / max(group->sgp->power, 1);
 
        /*
         * Consider the group unbalanced when the imbalance is larger


We found that reverting the commit:
cb83b62 (x86/sched/core) sched/numa: Rewrite the CONFIG_NUMA sched domain support

also got things working.

Thanks,
Robin Holt

             reply	other threads:[~2012-05-11 13:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 13:39 Robin Holt [this message]
2012-05-11 14:33 ` Commit cb83b62 fails to boot with a divide by zero error Peter Zijlstra
2012-05-11 15:05   ` Robin Holt
2012-05-11 15:36     ` Peter Zijlstra
2012-05-11 15:55       ` Robin Holt
2012-05-11 16:01         ` Peter Zijlstra
2012-05-14 10:48         ` Ingo Molnar
2012-05-14 12:40           ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120511133938.GG3751@sgi.com \
    --to=holt@sgi.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.