From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Date: Fri, 11 May 2012 14:17:54 -0700 Message-ID: <20120511141754.e0719c26.akpm@linux-foundation.org> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4FACDFAE.5050808-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: KAMEZAWA Hiroyuki Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , Tejun Heo , "Aneesh Kumar K.V" , Hiroyuki Kamezawa , Linux Kernel On Fri, 11 May 2012 18:45:18 +0900 KAMEZAWA Hiroyuki wrote: > The conditions are handled as -EBUSY, _now_. The changelog is poor. I rewrote it to : hugetlb_force_memcg_empty() incorrectly returns 0 (success) when the : cgroup is found to be busy. Return -EBUSY instead. But it still doesn't tell us the end-user-visible effects of the bug. It should. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx102.postini.com [74.125.245.102]) by kanga.kvack.org (Postfix) with SMTP id 3B58A8D0001 for ; Fri, 11 May 2012 17:17:57 -0400 (EDT) Date: Fri, 11 May 2012 14:17:54 -0700 From: Andrew Morton Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Message-Id: <20120511141754.e0719c26.akpm@linux-foundation.org> In-Reply-To: <4FACDFAE.5050808@jp.fujitsu.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , Tejun Heo , "Aneesh Kumar K.V" , Hiroyuki Kamezawa , Linux Kernel On Fri, 11 May 2012 18:45:18 +0900 KAMEZAWA Hiroyuki wrote: > The conditions are handled as -EBUSY, _now_. The changelog is poor. I rewrote it to : hugetlb_force_memcg_empty() incorrectly returns 0 (success) when the : cgroup is found to be busy. Return -EBUSY instead. But it still doesn't tell us the end-user-visible effects of the bug. It should. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946107Ab2EKVR6 (ORCPT ); Fri, 11 May 2012 17:17:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33708 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933263Ab2EKVR4 (ORCPT ); Fri, 11 May 2012 17:17:56 -0400 Date: Fri, 11 May 2012 14:17:54 -0700 From: Andrew Morton To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , Tejun Heo , "Aneesh Kumar K.V" , Hiroyuki Kamezawa , Linux Kernel Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Message-Id: <20120511141754.e0719c26.akpm@linux-foundation.org> In-Reply-To: <4FACDFAE.5050808@jp.fujitsu.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 May 2012 18:45:18 +0900 KAMEZAWA Hiroyuki wrote: > The conditions are handled as -EBUSY, _now_. The changelog is poor. I rewrote it to : hugetlb_force_memcg_empty() incorrectly returns 0 (success) when the : cgroup is found to be busy. Return -EBUSY instead. But it still doesn't tell us the end-user-visible effects of the bug. It should.