From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH] unmodified_drivers: remove inclusion of asm/system.h Date: Fri, 11 May 2012 18:21:03 +0200 Message-ID: <20120511162103.GA24144@aepfle.de> References: <1336751953.23818.118.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1336751953.23818.118.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Fri, May 11, Ian Campbell wrote: > On Fri, 2012-05-11 at 15:35 +0100, Olaf Hering wrote: > > # HG changeset patch > > # User Olaf Hering > > # Date 1336743357 -7200 > > # Node ID f81fa4014d8c66bd1a80e4914c5d777cbdb343d1 > > # Parent 0f53540494f779a1260d4e5319dcdb268389dd07 > > unmodified_drivers: remove inclusion of asm/system.h > > > > Allow compilation of PVonHVM drivers with forward-ported xenlinux > > sources in openSuSE 12.2. Since Linux 3.4 asm/system.h is not present > > anymore. Remove inclusion of this header, its not needed. > > It is not needed for 3.4 or it is not needed for any historical Linux > version which these drivers are supposed to be built against? What > kernels have you build tested? asm/system.h does not need to be included. I tested it with sles11sp1+2, opensuse 11.2, 11.4, 12.1 and 12.2. I have not tested it with a plain linux-2.6.18-xen.hg, but I suspect it should work there too. Olaf