From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Laxman Dewangan <ldewangan@nvidia.com>,
linus.walleij@stericsson.com, sameo@linux.intel.com,
jedu@slimlogic.co.uk, lrg@slimlogic.co.uk,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] gpio: tps65910: move this as platform driver
Date: Fri, 11 May 2012 20:08:45 +0100 [thread overview]
Message-ID: <20120511190844.GA29835@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120511174011.3160B3E0791@localhost>
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Fri, May 11, 2012 at 11:40:11AM -0600, Grant Likely wrote:
> > +static int __init tps65910_gpio_init(void)
> > +{
> > + return platform_driver_register(&tps65910_gpio_driver);
> > +}
> > +subsys_initcall(tps65910_gpio_init);
> module_platform_driver()
This seems a little premature when we've not got many (any?) drivers
implementing -EPROBE_DEFER. If we got the change I posted to make
gpio_request() return -EPROBE_DEFER if there was no GPIO registered
that'd get most cases covered though, the drivers would hopefully pass
the error through.
I've not done this for regulators since the cpufreq drivers are still
deviceless so couldn't cope.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-11 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 13:10 [PATCH 0/4] mfd:tps65910: use devm_* and register gpio as platform driver Laxman Dewangan
2012-05-09 13:10 ` [PATCH 1/4] mfd: tps65910: cache register when we need it Laxman Dewangan
2012-05-09 14:55 ` Mark Brown
2012-05-09 13:10 ` [PATCH 2/4] mfd: tps65910: convert all allocation to devm_* Laxman Dewangan
2012-05-09 15:11 ` Mark Brown
2012-05-09 13:10 ` [PATCH 3/4] mfd: tps65910: register gpio as mfd device Laxman Dewangan
2012-05-09 13:10 ` [PATCH 4/4] gpio: tps65910: move this as platform driver Laxman Dewangan
2012-05-11 17:40 ` Grant Likely
2012-05-11 19:08 ` Mark Brown [this message]
2012-05-11 13:14 ` [PATCH 0/4] mfd:tps65910: use devm_* and register gpio " Samuel Ortiz
2012-05-11 13:18 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511190844.GA29835@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=grant.likely@secretlab.ca \
--cc=jedu@slimlogic.co.uk \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.