All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Prefix non-static functions with batadv_
Date: Fri, 11 May 2012 21:23:47 +0200	[thread overview]
Message-ID: <20120511192347.GA14707@lunn.ch> (raw)
In-Reply-To: <1336760987-1523-1-git-send-email-sven@narfation.org>

On Fri, May 11, 2012 at 08:29:46PM +0200, Sven Eckelmann wrote:
> batman-adv can be compiled as part of the kernel instead of an module. In that
> case the linker will see all non-static symbols of batman-adv and all other
> non-static symbols of the kernel. This could lead to symbol collisions. A
> prefix for the batman-adv symbols that defines their private namespace avoids
> such a problem.

Hi Sven

Two probably dumb questions...

1) Did you use objdump to check for any symbols you missed?

2) A quick look at the patch suggests its changing function names. Are
   there any variables with global scope?

Thanks
	Andrew   

  parent reply	other threads:[~2012-05-11 19:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 18:29 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Prefix non-static functions with batadv_ Sven Eckelmann
2012-05-11 18:29 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix namespace for hash_set_lock_class Sven Eckelmann
2012-05-11 19:15 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Prefix non-static functions with batadv_ Marek Lindner
2012-05-11 19:23 ` Andrew Lunn [this message]
2012-05-11 19:31   ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120511192347.GA14707@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.