From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()
Date: Fri, 11 May 2012 21:25:27 +0200 [thread overview]
Message-ID: <20120511192527.6DF4020348D@gemini.denx.de> (raw)
In-Reply-To: <1336671134-16342-4-git-send-email-michael@walle.cc>
Dear Michael Walle,
In message <1336671134-16342-4-git-send-email-michael@walle.cc> you wrote:
> Signed-off-by: Michael Walle <michael@walle.cc>
How many boards will be using this code?
Eventually this should be made configurable?
> + sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
This should generate a warning: too many arguments for format.
Please fix.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the pitiful, multipage, connection-boxed form to which the flow-
chart has today been elaborated, it has proved to be useless as a
design tool -- programmers draw flowcharts after, not before, writing
the programs they describe. - Fred Brooks, Jr.
next prev parent reply other threads:[~2012-05-11 19:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 17:32 [U-Boot] [PATCH v4 0/3] net: helper functions Michael Walle
2012-05-10 17:32 ` [U-Boot] [PATCH v4 1/3] lib: add rand() function Michael Walle
2012-05-11 19:20 ` Wolfgang Denk
2012-05-11 20:32 ` Michael Walle
2012-05-11 20:43 ` Wolfgang Denk
[not found] ` <201205112249.27871.michael@walle.cc>
2012-05-11 21:11 ` Wolfgang Denk
2012-05-11 21:20 ` Michael Walle
2012-05-11 21:29 ` Wolfgang Denk
2012-05-11 21:34 ` Michael Walle
2012-05-10 17:32 ` [U-Boot] [PATCH v4 2/3] net: add helper to generate random mac address Michael Walle
2012-05-11 19:21 ` Wolfgang Denk
2012-05-14 5:43 ` Mike Frysinger
2012-05-10 17:32 ` [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index() Michael Walle
2012-05-11 19:25 ` Wolfgang Denk [this message]
2012-05-11 21:01 ` Michael Walle
2012-05-11 21:16 ` Wolfgang Denk
2012-05-11 22:12 ` Michael Walle
2012-05-11 16:32 ` [U-Boot] [PATCH v4 0/3] net: helper functions Michael Walle
2012-05-11 16:46 ` Joe Hershberger
2012-05-11 16:51 ` Prafulla Wadaskar
2012-05-21 20:52 ` Michael Walle
2012-05-11 19:18 ` Wolfgang Denk
2012-05-11 20:29 ` Michael Walle
2012-05-11 20:43 ` Wolfgang Denk
2012-05-11 20:54 ` Michael Walle
2012-05-11 21:14 ` Wolfgang Denk
2012-05-11 21:22 ` Michael Walle
2012-05-11 21:30 ` Wolfgang Denk
2012-05-11 21:42 ` Michael Walle
2012-05-11 21:55 ` Wolfgang Denk
2012-05-14 5:42 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511192527.6DF4020348D@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.