From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Walle <michael@walle.cc>
Date: Fri, 11 May 2012 23:01:49 +0200
Subject: [U-Boot] [PATCH v4 3/3] net: add eth_setenv_enetaddr_by_index()
In-Reply-To: <20120511192527.6DF4020348D@gemini.denx.de>
References: <1336671134-16342-1-git-send-email-michael@walle.cc>
	<1336671134-16342-4-git-send-email-michael@walle.cc>
	<20120511192527.6DF4020348D@gemini.denx.de>
Message-ID: <201205112301.50311.michael@walle.cc>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Am Freitag 11 Mai 2012, 21:25:27 schrieb Wolfgang Denk:
> Dear Michael Walle,
> 
> In message <1336671134-16342-4-git-send-email-michael@walle.cc> you wrote:
> > Signed-off-by: Michael Walle <michael@walle.cc>
> 
> How many boards will be using this code?
Hopefully more boars will use this function in the future, instead of messing 
around with the variable names themselves.

> Eventually this should be made configurable?
Given the above, i would keep it non-configurable if youre fine with that.

> 
> > +	sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
> 
> This should generate a warning: too many arguments for format.
Mh, nice catch. That was just copied from the eth_getenv_enetaddr_by_index() 
function. I'll fix all of them.

-- 
michael