All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: lenb@kernel.org, linux-usb@vger.kernel.org,
	linux-acpi@vger.kernel.org, stern@rowland.harvard.edu,
	sarah.a.sharp@linux.intel.com, mjg59@srcf.ucam.org,
	mfm@muteddisk.com
Subject: Re: [Resend PATCH V3 6/8] usb: move struct usb_device->children to struct usb_hub_port->child
Date: Fri, 11 May 2012 17:10:27 -0700	[thread overview]
Message-ID: <20120512001027.GA25600@kroah.com> (raw)
In-Reply-To: <1336723712-7686-7-git-send-email-tianyu.lan@intel.com>

On Fri, May 11, 2012 at 04:08:30PM +0800, Lan Tianyu wrote:

> +struct usb_device *usb_get_hub_child_device(struct usb_device *hdev,
> +	int port1)
> +{
> +	struct usb_hub *hub = hdev_to_hub(hdev);
> +
> +	if (!hub || port1 > hdev->maxchild || port1 < 1)
> +		return NULL;
> +	return hub->port_data[port1 - 1].child;
> +}
> +EXPORT_SYMBOL_GPL(usb_get_hub_child_device);

We need kerneldoc documentation for this new public function.  Please
send a follow-on patch that adds this.

thanks,

greg k-h

  reply	other threads:[~2012-05-12  0:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11  8:08 [Resend PATCH V3 0/8] usb/acpi: Add binding usb device with acpi Lan Tianyu
2012-05-11  8:08 ` [Resend PATCH V3 3/8] usb: Bind devices to ACPI devices when possible Lan Tianyu
2012-05-11  8:08 ` [Resend PATCH V3 4/8] usb: Set device removable state based on ACPI USB data Lan Tianyu
2012-05-11  8:08 ` [Resend PATCH V3 5/8] usb: add struct usb_hub_port to store port related members Lan Tianyu
2012-05-11  8:08 ` [Resend PATCH V3 7/8] usb/acpi: add the support of usb hub ports' acpi binding without attached devices Lan Tianyu
     [not found]   ` <1336723712-7686-8-git-send-email-tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-05-12  0:15     ` Greg KH
2012-05-12 16:00       ` Lan Tianyu
2012-05-12 16:26         ` Greg KH
     [not found] ` <1336723712-7686-1-git-send-email-tianyu.lan-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2012-05-11  8:08   ` [Resend PATCH V3 1/8] ACPI: Add stubs for (un)register_acpi_bus_type Lan Tianyu
2012-05-11  8:08   ` [Resend PATCH V3 2/8] ACPI: Add _PLD support Lan Tianyu
2012-05-11  8:08   ` [Resend PATCH V3 6/8] usb: move struct usb_device->children to struct usb_hub_port->child Lan Tianyu
2012-05-12  0:10     ` Greg KH [this message]
     [not found]       ` <20120512001027.GA25600-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-05-12 15:31         ` Lan Tianyu
2012-05-11  8:08   ` [Resend PATCH V3 8/8] usb/acpi: add usb check for the connect type of usb port Lan Tianyu
2012-05-12  0:26 ` [Resend PATCH V3 0/8] usb/acpi: Add binding usb device with acpi Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120512001027.GA25600@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mfm@muteddisk.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=sarah.a.sharp@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tianyu.lan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.