From: Marek Lindner <lindner_marek@yahoo.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Prefix non-static functions with batadv_
Date: Sat, 12 May 2012 03:15:19 +0800 [thread overview]
Message-ID: <201205120315.19641.lindner_marek@yahoo.de> (raw)
In-Reply-To: <1336760987-1523-1-git-send-email-sven@narfation.org>
On Saturday, May 12, 2012 02:29:46 Sven Eckelmann wrote:
> @@ -138,7 +138,8 @@ static uint8_t hop_penalty(uint8_t tq, const struct
> bat_priv *bat_priv) static int bat_iv_ogm_aggr_packet(int buff_pos, int
> packet_len,
> int tt_num_changes)
> {
> - int next_buff_pos = buff_pos + BATMAN_OGM_HLEN +
> tt_len(tt_num_changes); + int next_buff_pos = buff_pos +
> BATMAN_OGM_HLEN +
> + batadv_tt_len(tt_num_changes);
>
> return (next_buff_pos <= packet_len) &&
> (next_buff_pos <= MAX_AGGREGATION_BYTES);
> @@ -189,7 +190,7 @@ static void bat_iv_ogm_send_to_if(struct forw_packet
> *forw_packet, hard_iface->net_dev->dev_addr);
>
> buff_pos += BATMAN_OGM_HLEN +
> - tt_len(batman_ogm_packet->tt_num_changes);
> + batadv_tt_len(batman_ogm_packet->tt_num_changes
> ); packet_num++;
> batman_ogm_packet = (struct batman_ogm_packet *)
> (forw_packet->skb->data +
> buff_pos);
Here we have indentation David does not like (although not problematic for
checkpatch).
> @@ -1222,7 +1226,7 @@ static int bat_iv_ogm_receive(struct sk_buff *skb,
> tt_buff, if_incoming);
>
> buff_pos += BATMAN_OGM_HLEN +
> - tt_len(batman_ogm_packet->tt_num_changes);
> + batadv_tt_len(batman_ogm_packet-
>tt_num_changes);
>
> batman_ogm_packet = (struct batman_ogm_packet *)
> (packet_buff + buff_pos);
Same here.
Regards,
Marek
next prev parent reply other threads:[~2012-05-11 19:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 18:29 [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Prefix non-static functions with batadv_ Sven Eckelmann
2012-05-11 18:29 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: Fix namespace for hash_set_lock_class Sven Eckelmann
2012-05-11 19:15 ` Marek Lindner [this message]
2012-05-11 19:23 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: Prefix non-static functions with batadv_ Andrew Lunn
2012-05-11 19:31 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205120315.19641.lindner_marek@yahoo.de \
--to=lindner_marek@yahoo.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.