All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>,
	devel@driverdev.osuosl.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH] iio: Remove unused iio_device_put()
Date: Sat, 12 May 2012 07:33:03 -0700	[thread overview]
Message-ID: <20120512143303.GA1972@kroah.com> (raw)
In-Reply-To: <4FAE7296.90903@metafoo.de>

On Sat, May 12, 2012 at 04:24:22PM +0200, Lars-Peter Clausen wrote:
> On 05/12/2012 04:18 PM, Greg Kroah-Hartman wrote:
> > On Fri, May 11, 2012 at 03:13:13PM +0200, Lars-Peter Clausen wrote:
> >> This function is currently unused and we do not have a matching iio_device_get()
> >> function either, so just remove it.
> >>
> >> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> >> Acked-by: Jonathan Cameron <jic23@kernel.org>
> > 
> > No, I see a number of places it should be used.  Don't do "raw"
> > put_device() calls, every one of them could be making this call instead,
> > right?
> 
> Hm, right in the new inkern code there are some put_device calls on
> indio_dev.dev, I missed those, sorry. But we should really add a matching
> iio_device_get() as well.

I agree, and then fix up the inkern.c calls to call that as well :)

thanks,

greg k-h

  reply	other threads:[~2012-05-12 14:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 13:13 [PATCH] iio: Remove unused iio_device_put() Lars-Peter Clausen
2012-05-12 14:18 ` Greg Kroah-Hartman
2012-05-12 14:24   ` Lars-Peter Clausen
2012-05-12 14:33     ` Greg Kroah-Hartman [this message]
2012-05-12 15:50       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120512143303.GA1972@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=jic23@cam.ac.uk \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.