All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2] hwmon: (it87) Convert to use devm_kzalloc and devm_request_region
Date: Sat, 12 May 2012 15:43:03 +0000	[thread overview]
Message-ID: <20120512154303.GA5854@ericsson.com> (raw)
In-Reply-To: <1336772553-12823-1-git-send-email-guenter.roeck@ericsson.com>

On Sat, May 12, 2012 at 11:39:51AM -0400, Jean Delvare wrote:
> On Fri, 11 May 2012 14:42:32 -0700, Guenter Roeck wrote:
> > From: Guenter Roeck <linux@roeck-us.net>
> > 
> > This makes the code a bit simpler and smaller.
> > 
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > v2: Also convert devm_request_region for further simplification
> > 
> >  drivers/hwmon/it87.c |   32 +++++++++-----------------------
> >  1 files changed, 9 insertions(+), 23 deletions(-)
> > (...)
> 
> Looks good.
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>
> 
> It might make sense to rename ERROR4 to something more meaningful? With
> only this label remaining, the name looks obscure.
> 
Makes sense. I'll do s/ERROR4/error/.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2012-05-12 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 21:42 [lm-sensors] [PATCH v2] hwmon: (it87) Convert to use devm_kzalloc and devm_request_region Guenter Roeck
2012-05-12 15:39 ` Jean Delvare
2012-05-12 15:43 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120512154303.GA5854@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.