From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: sameo@linux.intel.com, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, jonghwa3.lee@samsung.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] MFD: MAX77693: add IRQ handler
Date: Mon, 14 May 2012 10:57:20 +0100 [thread overview]
Message-ID: <20120514095719.GK31985@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1336972835-15203-1-git-send-email-cw00.choi@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On Mon, May 14, 2012 at 02:20:35PM +0900, Chanwoo Choi wrote:
> + if (!max77693->irq) {
> + dev_warn(max77693->dev, "No interrupt specified.\n");
> + return 0;
> + }
I'd suggest just setting up the IRQ domain anyway - it makes life
simpler in the other drivers for the chip as they don't need to worry if
interrupts are registered unless it's very important to them that they
go off which is often not the case. Just skip actually claiming the
IRQ.
> +EXPORT_SYMBOL_GPL(max77693_irq_resume);
> +EXPORT_SYMBOL_GPL(max77693_irq_init);
> +EXPORT_SYMBOL_GPL(max77693_irq_exit);
These shouldn't need to be exported, they're only used by the MFD core.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-14 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 5:20 [PATCH v3 2/2] MFD: MAX77693: add IRQ handler Chanwoo Choi
2012-05-14 9:57 ` Mark Brown [this message]
2012-05-14 10:06 ` Chanwoo Choi
2012-05-14 10:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514095719.GK31985@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.