All of lore.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Du, ChangbinX" <changbinx.du@intel.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
	"mina86@mina86.com" <mina86@mina86.com>,
	"Fleming, Matt" <matt.fleming@intel.com>,
	"balbi@ti.com" <balbi@ti.com>, "hpa@zytor.com" <hpa@zytor.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs
Date: Mon, 14 May 2012 08:39:29 -0700	[thread overview]
Message-ID: <20120514153929.GA1725@kroah.com> (raw)
In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A062DC8@SHSMSX101.ccr.corp.intel.com>

On Mon, May 14, 2012 at 10:49:06AM +0000, Du, ChangbinX wrote:
> 
> Hello.
> 
> On 14-05-2012 10:51, Du, ChangbinX wrote:
> 
> > As real device-nodes managed by udev whose nodes lived in /dev/bus/usb 
> > are mostly used today, let testusb tool use that directory as one 
> > default path make tool be more convenient to use.
> 
> > Signed-off-by: Du Changbin<changbinx.du@intel.com>
> > ---
> >   tools/usb/testusb.c |    6 ++++++
> >   1 file changed, 6 insertions(+)
> 
> > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c index 
> > 6e0f567..c6c839e 100644
> > --- a/tools/usb/testusb.c
> > +++ b/tools/usb/testusb.c
> [...]
> > @@ -376,6 +377,11 @@ static const char *usbfs_dir_find(void)
> >   		}
> >   	} while (++it != end);
> >
> > +	/* real device-nodes managed by udev */
> > +	if (access(udev_usb_path, F_OK) == 0) {
> > +		return udev_usb_path;
> > +	}
> 
>     Why {} with single statement?
> 
> Hi, thanks for your tip. It's a code style issue. I will remove {}.
> 
> By the way, I don't know how I can do with this case? Resend a new
> patch? Do I need include discussion message in new patch mail?

Please resend a new patch with this fixed up.

> And how can I know my patch has be accepted? I am a newbie, could you
> help me?

You will get an automated email from my patch system when it is applied.

thanks,

greg k-h

      parent reply	other threads:[~2012-05-14 15:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1337021163-1487-1-git-send-email-changbinx.du@intel.com>
2012-05-14  6:51 ` [PATCH] testusb: add path /dev/bus/usb to default search paths for usbfs Du, ChangbinX
2012-05-14  9:59   ` Sergei Shtylyov
2012-05-14 10:49     ` Du, ChangbinX
2012-05-14 11:27       ` Sergei Shtylyov
2012-05-15  1:52         ` Du, ChangbinX
2012-05-14 15:39       ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514153929.GA1725@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@ti.com \
    --cc=changbinx.du@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=matt.fleming@intel.com \
    --cc=mina86@mina86.com \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.