All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <axboe@kernel.dk>, NeilBrown <neilb@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] floppy: remove floppy-specific O_EXCL handling
Date: Mon, 14 May 2012 09:25:21 -0700	[thread overview]
Message-ID: <20120514162521.GA2366@google.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1205131059410.15448@pobox.suse.cz>

Hello,

On Sun, May 13, 2012 at 11:02:07AM +0200, Jiri Kosina wrote:
> Block layer now handles O_EXCL in a generic way for block devices.
> 
> The semantics is however different for floppy and all other block devices,
> as floppy driver contains its own O_EXCL handling.
> 
> The semantics for all-but-floppy bdevs is "there can be at most one O_EXCL 
> open of this file", while for floppy bdev the semantics is "if someone has 
> the bdev open with O_EXCL, noone else can open it".
> 
> Remove the floppy-specific handling and let the generic bdev code O_EXCL
> handling take over.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Patch looks good to me but why do we want to change this at this
point?

Thanks.

-- 
tejun

  reply	other threads:[~2012-05-14 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-13  9:02 [PATCH] floppy: remove floppy-specific O_EXCL handling Jiri Kosina
2012-05-14 16:25 ` Tejun Heo [this message]
2012-05-14 16:49   ` Joe Perches
2012-05-14 20:42   ` Jiri Kosina
2012-05-14 21:19     ` Tejun Heo
2012-05-14 21:38       ` Jiri Kosina
2012-05-14 23:22         ` NeilBrown
2012-05-15  6:15           ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514162521.GA2366@google.com \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=jkosina@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.