From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Joe Perches <joe@perches.com>, Jason Wang <jasowang@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Ian.Campbell@citrix.com, kvm@vger.kernel.org
Subject: Re: [PATCH RFC] tun: experimental zero copy tx support
Date: Mon, 14 May 2012 20:04:13 +0300 [thread overview]
Message-ID: <20120514170412.GA17086@redhat.com> (raw)
In-Reply-To: <20120514095446.3ce307d2@nehalam.linuxnetplumber.net>
On Mon, May 14, 2012 at 09:54:46AM -0700, Stephen Hemminger wrote:
> On Sun, 13 May 2012 18:52:06 +0300
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > + /* Userspace may produce vectors with count greater than
> > + * MAX_SKB_FRAGS, so we need to linearize parts of the skb
> > + * to let the rest of data to be fit in the frags.
> > + */
> Rather than complex partial code, just go through slow path for
> requests with too many frags (or for really small requests).
> Creating mixed skb's seems too easy to get wrong.
I don't object in principle but macvtap has same code
so seems better to stay consistent.
--
MST
next prev parent reply other threads:[~2012-05-14 17:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 15:52 [PATCH RFC] tun: experimental zero copy tx support Michael S. Tsirkin
2012-05-14 16:54 ` Stephen Hemminger
2012-05-14 17:04 ` Michael S. Tsirkin [this message]
2012-05-14 19:02 ` Eric Dumazet
2012-05-14 19:14 ` Michael S. Tsirkin
2012-05-14 19:17 ` Michael S. Tsirkin
2012-05-14 19:21 ` Eric Dumazet
2012-05-14 19:31 ` Michael S. Tsirkin
2012-05-15 18:00 ` Shirley Ma
2012-05-14 17:34 ` Shirley Ma
2012-05-14 18:39 ` Michael S. Tsirkin
2012-05-16 15:16 ` Shirley Ma
2012-05-16 16:51 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514170412.GA17086@redhat.com \
--to=mst@redhat.com \
--cc=Ian.Campbell@citrix.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=joe@perches.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.