From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Date: Mon, 14 May 2012 11:15:56 -0700 Message-ID: <20120514181556.GE2366@google.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=KOLEb2uYJD8TpCrAg9Vo1Z7u99ORz3SogbtENCWXQSQ=; b=l8DscEpQmAuWSJrYK8AFVX8HbL1ZMAupbc4AQC7M8wOGmrxJvrHj7rxKlp9U2F680V QGEHlHrjZGabCNeQEms+s6TcYFJYoVng0t0qiznD6uDnqY7sIe8jkwUoFEmNQ7lt2Ogl qyzKMfYhwgE/GS63qDW2KcOwVXU2iQAU3UPHmVrrzm9dLe6qjbkgREM5LyF+G8VG8eTG WMd9wUn9Kbjnm+qgggnlmEFZLn855iJfbgI/MRwQZIyZ48OIF+CM9gKVg+rnL/04yakm 0SC7bzLRD9KmI+lHiX43/etaQCC3O5HqJ96vdDa+PH5aQPj/CUX2r8deK9Uycqto7xR5 DA5g== Content-Disposition: inline In-Reply-To: <4FACDFAE.5050808-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: KAMEZAWA Hiroyuki Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote: > - if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) > + if (cgroup_task_count(cgroup) > + || !list_empty(&cgroup->children)) { > + ret = -EBUSY; > goto out; Why break the line? It doesn't go over 80 col. Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx204.postini.com [74.125.245.204]) by kanga.kvack.org (Postfix) with SMTP id 40B366B00F5 for ; Mon, 14 May 2012 14:16:01 -0400 (EDT) Received: by pbbrp2 with SMTP id rp2so9275339pbb.14 for ; Mon, 14 May 2012 11:16:00 -0700 (PDT) Date: Mon, 14 May 2012 11:15:56 -0700 From: Tejun Heo Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Message-ID: <20120514181556.GE2366@google.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FACDFAE.5050808@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote: > - if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) > + if (cgroup_task_count(cgroup) > + || !list_empty(&cgroup->children)) { > + ret = -EBUSY; > goto out; Why break the line? It doesn't go over 80 col. Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932134Ab2ENSQD (ORCPT ); Mon, 14 May 2012 14:16:03 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:46570 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757327Ab2ENSQB (ORCPT ); Mon, 14 May 2012 14:16:01 -0400 Date: Mon, 14 May 2012 11:15:56 -0700 From: Tejun Heo To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Message-ID: <20120514181556.GE2366@google.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FACDFAE.5050808@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote: > - if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) > + if (cgroup_task_count(cgroup) > + || !list_empty(&cgroup->children)) { > + ret = -EBUSY; > goto out; Why break the line? It doesn't go over 80 col. Thanks. -- tejun