From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: KAMEZAWA Hiroyuki
<kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: Frederic Weisbecker
<fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org"
<linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
"cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
Han Ying <yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>,
"Aneesh Kumar K.V"
<aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
Hiroyuki Kamezawa
<kamezawa.hiroyuki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linux Kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/6] add res_counter_uncharge_until()
Date: Mon, 14 May 2012 11:17:25 -0700 [thread overview]
Message-ID: <20120514181725.GF2366@google.com> (raw)
In-Reply-To: <4FB0DF4A.5010506-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
On Mon, May 14, 2012 at 07:32:42PM +0900, KAMEZAWA Hiroyuki wrote:
> [PATCH 2/6] memcg: add res_counter_uncharge_until()
>
> From: Frederic Weisbecker <fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> At killing res_counter which is a child of other counter,
> we need to do
> res_counter_uncharge(child, xxx)
> res_counter_charge(parent, xxx)
>
> This is not atomic and wasting cpu. This patch adds
> res_counter_uncharge_until(). This function's uncharge propagates
> to ancestors until specified res_counter.
>
> res_counter_uncharge_until(child, parent, xxx)
>
> Now, ops is atomic and efficient.
>
> Changelog since v2
> - removed unnecessary lines.
> - added 'From' , this patch comes from his one.
>
> Signed-off-by: Frederic Weisbecker <fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Acked-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Thanks.
--
tejun
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Han Ying <yinghan@google.com>,
Glauber Costa <glommer@parallels.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Hiroyuki Kamezawa <kamezawa.hiroyuki@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] add res_counter_uncharge_until()
Date: Mon, 14 May 2012 11:17:25 -0700 [thread overview]
Message-ID: <20120514181725.GF2366@google.com> (raw)
In-Reply-To: <4FB0DF4A.5010506@jp.fujitsu.com>
On Mon, May 14, 2012 at 07:32:42PM +0900, KAMEZAWA Hiroyuki wrote:
> [PATCH 2/6] memcg: add res_counter_uncharge_until()
>
> From: Frederic Weisbecker <fweisbec@gmail.com>
>
> At killing res_counter which is a child of other counter,
> we need to do
> res_counter_uncharge(child, xxx)
> res_counter_charge(parent, xxx)
>
> This is not atomic and wasting cpu. This patch adds
> res_counter_uncharge_until(). This function's uncharge propagates
> to ancestors until specified res_counter.
>
> res_counter_uncharge_until(child, parent, xxx)
>
> Now, ops is atomic and efficient.
>
> Changelog since v2
> - removed unnecessary lines.
> - added 'From' , this patch comes from his one.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Han Ying <yinghan@google.com>,
Glauber Costa <glommer@parallels.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Hiroyuki Kamezawa <kamezawa.hiroyuki@gmail.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] add res_counter_uncharge_until()
Date: Mon, 14 May 2012 11:17:25 -0700 [thread overview]
Message-ID: <20120514181725.GF2366@google.com> (raw)
In-Reply-To: <4FB0DF4A.5010506@jp.fujitsu.com>
On Mon, May 14, 2012 at 07:32:42PM +0900, KAMEZAWA Hiroyuki wrote:
> [PATCH 2/6] memcg: add res_counter_uncharge_until()
>
> From: Frederic Weisbecker <fweisbec@gmail.com>
>
> At killing res_counter which is a child of other counter,
> we need to do
> res_counter_uncharge(child, xxx)
> res_counter_charge(parent, xxx)
>
> This is not atomic and wasting cpu. This patch adds
> res_counter_uncharge_until(). This function's uncharge propagates
> to ancestors until specified res_counter.
>
> res_counter_uncharge_until(child, parent, xxx)
>
> Now, ops is atomic and efficient.
>
> Changelog since v2
> - removed unnecessary lines.
> - added 'From' , this patch comes from his one.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2012-05-14 18:17 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 9:41 [PATCH v3][0/6] memcg: prevent -ENOMEM in pre_destroy() KAMEZAWA Hiroyuki
2012-05-11 9:41 ` KAMEZAWA Hiroyuki
2012-05-11 9:41 ` KAMEZAWA Hiroyuki
2012-05-11 9:45 ` [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() KAMEZAWA Hiroyuki
2012-05-11 9:45 ` KAMEZAWA Hiroyuki
[not found] ` <4FACDFAE.5050808-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-05-11 21:17 ` Andrew Morton
2012-05-11 21:17 ` Andrew Morton
2012-05-11 21:17 ` Andrew Morton
[not found] ` <20120511141754.e0719c26.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-05-14 1:07 ` KAMEZAWA Hiroyuki
2012-05-14 1:07 ` KAMEZAWA Hiroyuki
2012-05-14 1:07 ` KAMEZAWA Hiroyuki
2012-05-14 18:15 ` Tejun Heo
2012-05-14 18:15 ` Tejun Heo
2012-05-14 18:15 ` Tejun Heo
[not found] ` <20120514181556.GE2366-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-14 18:32 ` Tejun Heo
2012-05-14 18:32 ` Tejun Heo
2012-05-14 18:32 ` Tejun Heo
[not found] ` <20120514183219.GG2366-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-15 1:10 ` KAMEZAWA Hiroyuki
2012-05-15 1:10 ` KAMEZAWA Hiroyuki
2012-05-15 1:10 ` KAMEZAWA Hiroyuki
2012-05-15 15:12 ` Tejun Heo
2012-05-15 15:12 ` Tejun Heo
2012-05-11 9:47 ` [PATCH 2/6] add res_counter_uncharge_until() KAMEZAWA Hiroyuki
2012-05-11 9:47 ` KAMEZAWA Hiroyuki
[not found] ` <4FACE01A.4040405-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-05-11 21:19 ` Andrew Morton
2012-05-11 21:19 ` Andrew Morton
2012-05-11 21:19 ` Andrew Morton
[not found] ` <20120511141945.c487e94c.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-05-14 1:10 ` KAMEZAWA Hiroyuki
2012-05-14 1:10 ` KAMEZAWA Hiroyuki
2012-05-14 1:10 ` KAMEZAWA Hiroyuki
2012-05-14 10:08 ` Frederic Weisbecker
2012-05-14 10:08 ` Frederic Weisbecker
[not found] ` <CAFTL4hwGEhyxZO0sXx5gVyK_xjhMQEbHojJbHzQmVKafNyVWtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-05-14 10:32 ` KAMEZAWA Hiroyuki
2012-05-14 10:32 ` KAMEZAWA Hiroyuki
2012-05-14 10:32 ` KAMEZAWA Hiroyuki
[not found] ` <4FB0DF4A.5010506-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-05-14 10:56 ` Frederic Weisbecker
2012-05-14 10:56 ` Frederic Weisbecker
2012-05-14 10:56 ` Frederic Weisbecker
2012-05-14 18:17 ` Tejun Heo [this message]
2012-05-14 18:17 ` Tejun Heo
2012-05-14 18:17 ` Tejun Heo
2012-05-11 9:48 ` [PATCH v3 3/6] memcg: use res_counter_uncharge_until in move_parent() KAMEZAWA Hiroyuki
2012-05-11 9:48 ` KAMEZAWA Hiroyuki
[not found] ` <4FACDED0.3020400-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-05-11 9:49 ` [PATCH v3 4/6] memcg: move charges to root cgroup if use_hierarchy=0 KAMEZAWA Hiroyuki
2012-05-11 9:49 ` KAMEZAWA Hiroyuki
2012-05-11 9:49 ` KAMEZAWA Hiroyuki
[not found] ` <4FACE0A2.30608-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-05-14 20:14 ` Tejun Heo
2012-05-14 20:14 ` Tejun Heo
2012-05-14 20:14 ` Tejun Heo
[not found] ` <20120514201438.GI2366-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-15 0:04 ` KAMEZAWA Hiroyuki
2012-05-15 0:04 ` KAMEZAWA Hiroyuki
2012-05-15 0:04 ` KAMEZAWA Hiroyuki
2012-05-11 9:50 ` [PATCH v3 5/6] memcg: don't uncharge in mem_cgroup_move_account KAMEZAWA Hiroyuki
2012-05-11 9:50 ` KAMEZAWA Hiroyuki
2012-05-11 9:50 ` KAMEZAWA Hiroyuki
2012-05-11 9:53 ` [PATCH v3 6/6] remove __must_check for res_counter_charge_nofail() KAMEZAWA Hiroyuki
2012-05-11 9:53 ` KAMEZAWA Hiroyuki
2012-05-11 9:53 ` KAMEZAWA Hiroyuki
[not found] ` <4FACE184.6020307-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-05-14 20:09 ` Tejun Heo
2012-05-14 20:09 ` Tejun Heo
2012-05-14 20:09 ` Tejun Heo
[not found] ` <20120514200925.GH2366-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-05-15 0:02 ` KAMEZAWA Hiroyuki
2012-05-15 0:02 ` KAMEZAWA Hiroyuki
2012-05-15 0:02 ` KAMEZAWA Hiroyuki
2012-06-21 20:20 ` [PATCH v3][0/6] memcg: prevent -ENOMEM in pre_destroy() Tejun Heo
2012-06-21 20:20 ` Tejun Heo
2012-06-21 20:20 ` Tejun Heo
[not found] ` <20120621202043.GD4642-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-06-21 23:27 ` Kamezawa Hiroyuki
2012-06-21 23:27 ` Kamezawa Hiroyuki
2012-06-21 23:27 ` Kamezawa Hiroyuki
[not found] ` <4FE3ADDD.9060908-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-27 17:58 ` Tejun Heo
2012-06-27 17:58 ` Tejun Heo
2012-06-27 17:58 ` Tejun Heo
[not found] ` <20120627175818.GM15811-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-06-28 8:33 ` Kamezawa Hiroyuki
2012-06-28 8:33 ` Kamezawa Hiroyuki
2012-06-28 8:33 ` Kamezawa Hiroyuki
[not found] ` <4FEC16EF.40408-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2012-06-28 16:06 ` Tejun Heo
2012-06-28 16:06 ` Tejun Heo
2012-06-28 16:06 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514181725.GF2366@google.com \
--to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fweisbec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=kamezawa.hiroyuki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=yinghan-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.