From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Date: Mon, 14 May 2012 11:32:19 -0700 Message-ID: <20120514183219.GG2366@google.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> <20120514181556.GE2366@google.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Nq6l2ygQ2DU1Xw7961ck9f7L9wO36D67eZXOqdRA46c=; b=Wye/xdOWePWZRsGoHqC5PnaXuFsAkqE9/t1SK+YXKVWWGs8wrLzwEWzotO0ttbO4P0 DBgfXoYeBjTW753Miewota02eZuRx8M4emvCN55T0pNDb0WqwFAQZgevFomO9I+ltLFE M7zzmSdE8LRf5/8BXesl+0KipglFkhMvcqn368AC171NnSXxcPAU0cV24untA5i6SdTX OhQ+XtB0S44EkCZ8GPWVWCyRtQnQFfXFngxqZctFEtmcQtxaJfjyOjjaAbCsKbkL1dn3 Ek0dUbYXzg/fHuQDquG/SXScBR9hETBL1WDNzPoFGkVTwhBbu3epUBe7DzTuMi/xjRq2 1ZlQ== Content-Disposition: inline In-Reply-To: <20120514181556.GE2366-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: KAMEZAWA Hiroyuki Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel On Mon, May 14, 2012 at 11:15:56AM -0700, Tejun Heo wrote: > On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote: > > - if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) > > + if (cgroup_task_count(cgroup) > > + || !list_empty(&cgroup->children)) { > > + ret = -EBUSY; > > goto out; > > Why break the line? It doesn't go over 80 col. Ooh, it does. Sorry, my bad. But still, isn't it more usual to leave the operator in the preceding line and align the start of the second line with the first? ie. if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) { Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx177.postini.com [74.125.245.177]) by kanga.kvack.org (Postfix) with SMTP id 341776B00F9 for ; Mon, 14 May 2012 14:32:24 -0400 (EDT) Received: by dakp5 with SMTP id p5so9057391dak.14 for ; Mon, 14 May 2012 11:32:23 -0700 (PDT) Date: Mon, 14 May 2012 11:32:19 -0700 From: Tejun Heo Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Message-ID: <20120514183219.GG2366@google.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> <20120514181556.GE2366@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120514181556.GE2366@google.com> Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel On Mon, May 14, 2012 at 11:15:56AM -0700, Tejun Heo wrote: > On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote: > > - if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) > > + if (cgroup_task_count(cgroup) > > + || !list_empty(&cgroup->children)) { > > + ret = -EBUSY; > > goto out; > > Why break the line? It doesn't go over 80 col. Ooh, it does. Sorry, my bad. But still, isn't it more usual to leave the operator in the preceding line and align the start of the second line with the first? ie. if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) { Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757538Ab2ENScZ (ORCPT ); Mon, 14 May 2012 14:32:25 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:51611 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757477Ab2ENScX (ORCPT ); Mon, 14 May 2012 14:32:23 -0400 Date: Mon, 14 May 2012 11:32:19 -0700 From: Tejun Heo To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Message-ID: <20120514183219.GG2366@google.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> <20120514181556.GE2366@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120514181556.GE2366@google.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 14, 2012 at 11:15:56AM -0700, Tejun Heo wrote: > On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote: > > - if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) > > + if (cgroup_task_count(cgroup) > > + || !list_empty(&cgroup->children)) { > > + ret = -EBUSY; > > goto out; > > Why break the line? It doesn't go over 80 col. Ooh, it does. Sorry, my bad. But still, isn't it more usual to leave the operator in the preceding line and align the start of the second line with the first? ie. if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) { Thanks. -- tejun