All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, ngupta@vflare.org, konrad.wilk@oracle.com,
	sjenning@linux.vnet.ibm.com
Subject: Re: [PATCH] ramster: switch over to zsmalloc and crypto interface
Date: Mon, 14 May 2012 13:06:59 -0700	[thread overview]
Message-ID: <20120514200659.GA15604@kroah.com> (raw)
In-Reply-To: <1336676781-8571-1-git-send-email-dan.magenheimer@oracle.com>

On Thu, May 10, 2012 at 12:06:21PM -0700, Dan Magenheimer wrote:
> RAMster does many zcache-like things.  In order to avoid major
> merge conflicts at 3.4, ramster used lzo1x directly for compression
> and retained a local copy of xvmalloc, while zcache moved to the
> new zsmalloc allocator and the crypto API.
> 
> This patch moves ramster forward to use zsmalloc and crypto.
> 
> Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>

I finally enabled building this one (didn't realize it required ZCACHE
to be disabled, I can only build one or the other), and I noticed after
this patch the following warnings in my build:

drivers/staging/ramster/zcache-main.c:950:13: warning: a??zcache_do_remotify_opsa?? defined but not used [-Wunused-function]
drivers/staging/ramster/zcache-main.c:1039:13: warning: a??ramster_remotify_inita?? defined but not used [-Wunused-function]
drivers/staging/ramster/zcache-main.c: In function a??zcache_puta??:
drivers/staging/ramster/zcache-main.c:1594:4: warning: a??pagea?? may be used uninitialized in this function [-Wuninitialized]
drivers/staging/ramster/zcache-main.c:1536:8: note: a??pagea?? was declared here

Care to please fix them up?

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, ngupta@vflare.org, konrad.wilk@oracle.com,
	sjenning@linux.vnet.ibm.com
Subject: Re: [PATCH] ramster: switch over to zsmalloc and crypto interface
Date: Mon, 14 May 2012 13:06:59 -0700	[thread overview]
Message-ID: <20120514200659.GA15604@kroah.com> (raw)
In-Reply-To: <1336676781-8571-1-git-send-email-dan.magenheimer@oracle.com>

On Thu, May 10, 2012 at 12:06:21PM -0700, Dan Magenheimer wrote:
> RAMster does many zcache-like things.  In order to avoid major
> merge conflicts at 3.4, ramster used lzo1x directly for compression
> and retained a local copy of xvmalloc, while zcache moved to the
> new zsmalloc allocator and the crypto API.
> 
> This patch moves ramster forward to use zsmalloc and crypto.
> 
> Signed-off-by: Dan Magenheimer <dan.magenheimer@oracle.com>

I finally enabled building this one (didn't realize it required ZCACHE
to be disabled, I can only build one or the other), and I noticed after
this patch the following warnings in my build:

drivers/staging/ramster/zcache-main.c:950:13: warning: ‘zcache_do_remotify_ops’ defined but not used [-Wunused-function]
drivers/staging/ramster/zcache-main.c:1039:13: warning: ‘ramster_remotify_init’ defined but not used [-Wunused-function]
drivers/staging/ramster/zcache-main.c: In function ‘zcache_put’:
drivers/staging/ramster/zcache-main.c:1594:4: warning: ‘page’ may be used uninitialized in this function [-Wuninitialized]
drivers/staging/ramster/zcache-main.c:1536:8: note: ‘page’ was declared here

Care to please fix them up?

thanks,

greg k-h

  parent reply	other threads:[~2012-05-14 20:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 19:06 [PATCH] ramster: switch over to zsmalloc and crypto interface Dan Magenheimer
2012-05-10 19:06 ` Dan Magenheimer
2012-05-10 19:28 ` Julian Andres Klode
2012-05-10 19:28   ` Julian Andres Klode
2012-05-11 16:23   ` Dan Magenheimer
2012-05-11 16:23     ` Dan Magenheimer
2012-05-11 18:00     ` Greg KH
2012-05-11 18:00       ` Greg KH
2012-05-14 20:06 ` Greg KH [this message]
2012-05-14 20:06   ` Greg KH
2012-05-14 20:45   ` Dan Magenheimer
2012-05-14 20:45     ` Dan Magenheimer
2012-05-14 22:41     ` Greg KH
2012-05-14 22:41       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514200659.GA15604@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ngupta@vflare.org \
    --cc=sjenning@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.