From: Johannes Weiner <hannes@cmpxchg.org>
To: Gavin Shan <shangw@linux.vnet.ibm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org
Subject: Re: [PATCH] mm/slab: remove duplicate check
Date: Mon, 14 May 2012 22:42:19 +0200 [thread overview]
Message-ID: <20120514204219.GC1406@cmpxchg.org> (raw)
In-Reply-To: <1336727769-19555-1-git-send-email-shangw@linux.vnet.ibm.com>
On Fri, May 11, 2012 at 05:16:09PM +0800, Gavin Shan wrote:
> While allocateing pages using buddy allocator, the compound page
> is probably split up to free pages. Under the circumstance, the
> compound page should be destroied by function destroy_compound_page().
> However, there has duplicate check to judge if the page is compound
> one.
>
> The patch removes the duplicate check since the function compound_order()
> will returns 0 while the page hasn't PG_head set in function destroy_compound_page().
> That's to say, the function destroy_compound_page() needn't check
> PG_head any more through function PageHead().
>
> Signed-off-by: Gavin Shan <shangw@linux.vnet.ibm.com>
Looks good!
But the slab in the subject suggests it would not affect other parts
of mm, while it actually affects THP, too. Should probably be
removed?
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-14 20:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 9:16 [PATCH] mm/slab: remove duplicate check Gavin Shan
2012-05-14 20:42 ` Johannes Weiner [this message]
2012-05-15 9:19 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514204219.GC1406@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=shangw@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.