From: Greg KH <gregkh@linuxfoundation.org>
To: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@gmail.com>
Cc: wfp5p@virginia.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: Staging: comedi: Clean up patch series.
Date: Mon, 14 May 2012 13:53:33 -0700 [thread overview]
Message-ID: <20120514205333.GA26338@kroah.com> (raw)
In-Reply-To: <1336732693-7408-1-git-send-email-ravishankar.km@greenturtles.in>
On Fri, May 11, 2012 at 04:07:48PM +0530, Ravishankar Karkala Mallikarjunayya wrote:
> This patch series fixes some style issues in drivers/staging/comedi/drivers
> and fix some issues found by checkpatch.pl script.
>
> Ravishankar Karkala Mallikarjunayya (25):
> Staging: comedi: fix printk issue in usbduxfast.c
> Staging: comedi: fix printk issues in usbduxfast.c
> Staging: comedi: fix printk issue in usbduxfast.c
> Staging: comedi: fix printk issue in usbduxfast.c
> Staging: comedi: fix printk issue in usbduxfast.c
> Staging: comedi: fix printk issue in usbduxfast.c
> Staging: comedi: fix printk issues in usbduxfast.c
> Staging: comedi: fix printk issue in rti800.c
> Staging: comedi: fix printk issue in rti802.c
> Staging: comedi: fix printk issue in s526.c
> Staging: comedi: fix printk issue in s626.c
> Staging: comedi: Checkpatch cleanups.
> Staging: comedi: Checkpatch cleanups.
> Staging: comedi: fix printk issue in serial2002.c
> Staging: comedi: fix printk issue in unioxx5.c
> Staging: comedi: fix printk issues in unioxx5.c
> Staging: comedi: fix line over 80 character issue in unioxx5.c
> Staging: comedi: Checkpatch cleanups.
> Staging: comedi: Checkpatch cleanups.
> Staging: comedi: Checkpatch cleanups.
> Staging: comedi: fix printk issue in pcmmio.c.
> Staging: comedi: fix printk issue in pcmad.c
> Staging: comedi: fix printk issue in poc.c
> Staging: comedi: fix printk issue in ni_pcimio.c
> Staging: comedi: fix printk issue in ni_660x.c
You have lots of duplicated Subject: lines in here, that are not
descriptive at all. You also do much the same exact thing in the same
exact files, yet you split it up into different patches for no apparent
reason at all.
Please rework this series to make one "logic" change per file, and make
better subject: lines that are understandable, I can't take any of these
as-is, sorry.
greg k-h
prev parent reply other threads:[~2012-05-14 20:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 10:37 Staging: comedi: Clean up patch series Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 01/25] Staging: comedi: fix printk issue in usbduxfast.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 02/25] Staging: comedi: fix printk issues " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 03/25] Staging: comedi: fix printk issue " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 04/25] " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 05/25] " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 06/25] " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 07/25] Staging: comedi: fix printk issues " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 08/25] Staging: comedi: fix printk issue in rti800.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 09/25] Staging: comedi: fix printk issue in rti802.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 10/25] Staging: comedi: fix printk issue in s526.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:37 ` [PATCH 11/25] Staging: comedi: fix printk issue in s626.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 12/25] Staging: comedi: Checkpatch cleanups Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 13/25] " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 14/25] Staging: comedi: fix printk issue in serial2002.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 15/25] Staging: comedi: fix printk issue in unioxx5.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 16/25] Staging: comedi: fix printk issues " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 17/25] Staging: comedi: fix line over 80 character issue " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 18/25] Staging: comedi: Checkpatch cleanups Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 19/25] " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 20/25] " Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 21/25] Staging: comedi: fix printk issue in pcmmio.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 22/25] Staging: comedi: fix printk issue in pcmad.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 23/25] Staging: comedi: fix printk issue in poc.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 24/25] Staging: comedi: fix printk issue in ni_pcimio.c Ravishankar Karkala Mallikarjunayya
2012-05-11 10:38 ` [PATCH 25/25] Staging: comedi: fix printk issue in ni_660x.c Ravishankar Karkala Mallikarjunayya
2012-05-14 20:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514205333.GA26338@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ravishankarkm32@gmail.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.