diff for duplicates of <20120514213634.GA3075@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 69528ef..ef07c26 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,19 +1,19 @@ -On Fri, May 11, 2012 at 7:58 PM, Saravana Kannan <skannan-sgV2jX0FEOJiIJoWrK/4GQ@public.gmane.orgg> wrote: +On Fri, May 11, 2012 at 7:58 PM, Saravana Kannan <skannan@codeaurora.org> wrote: > Mike, > > I was looking at the code to make the changes and I noticed this snippet > (reformatted for email) in clk_change_rate(): > -> if (clk->ops->set_rate) -> clk->ops->set_rate(clk->hw, clk->new_rate, -> clk->parent->rate); +> ? ? ? if (clk->ops->set_rate) +> ? ? ? ? ? ? ? ?clk->ops->set_rate(clk->hw, clk->new_rate, +> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?clk->parent->rate); > > -> if (clk->ops->recalc_rate) -> clk->rate = clk->ops->recalc_rate(clk->hw, -> clk->parent->rate); -> else -> clk->rate = clk->parent->rate; +> ? ? ? ?if (clk->ops->recalc_rate) +> ? ? ? ? ? ? ? ?clk->rate = clk->ops->recalc_rate(clk->hw, +> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?clk->parent->rate); +> ? ? ? ?else +> ? ? ? ? ? ? ? ?clk->rate = clk->parent->rate; > > I'm a bit confused. I thought recalc_rates was optional. But if I don't > implement it, the clocks rate will get set to parent's rate? Or is that a @@ -68,12 +68,12 @@ clk_change_rate? > Also, in clk_calc_new_rates(), > -> if (!clk->ops->round_rate) { -> top = clk_calc_new_rates(clk->parent, rate); -> new_rate = clk->parent->new_rate; +> ? ? ? ?if (!clk->ops->round_rate) { +> ? ? ? ? ? ? ? ?top = clk_calc_new_rates(clk->parent, rate); +> ? ? ? ? ? ? ? ?new_rate = clk->parent->new_rate; > -> goto out; -> } +> ? ? ? ? ? ? ? ?goto out; +> ? ? ? ?} > > Is the code assuming that if there is no round rate ops that that clock node > is only a gating clock (as in, can't change frequency the input freq)? Just diff --git a/a/content_digest b/N1/content_digest index f02125c..1c4b913 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,35 +7,28 @@ "ref\04FA9BD41.2090701@codeaurora.org\0" "ref\020120509103606.GY20304@tbergstrom-lnx.Nvidia.com\0" "ref\04FADD1EA.8090606@codeaurora.org\0" - "ref\04FADD1EA.8090606-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org\0" - "From\0Turquette, Mike <mturquette-l0cyMroinI0@public.gmane.org>\0" - "Subject\0Re: moving Tegra30 to the common clock framework\0" + "From\0mturquette@ti.com (Turquette, Mike)\0" + "Subject\0moving Tegra30 to the common clock framework\0" "Date\0Mon, 14 May 2012 14:36:34 -0700\0" - "To\0Saravana Kannan <skannan-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>\0" - "Cc\0Peter De Schrijver <pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>" - zhoujie wu <zhoujiewu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> - Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> - linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org> - " linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org <linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" - "On Fri, May 11, 2012 at 7:58 PM, Saravana Kannan <skannan-sgV2jX0FEOJiIJoWrK/4GQ@public.gmane.orgg> wrote:\n" + "On Fri, May 11, 2012 at 7:58 PM, Saravana Kannan <skannan@codeaurora.org> wrote:\n" "> Mike,\n" ">\n" "> I was looking at the code to make the changes and I noticed this snippet\n" "> (reformatted for email) in clk_change_rate():\n" ">\n" - "> \302\240 \302\240 \302\240 if (clk->ops->set_rate)\n" - "> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240clk->ops->set_rate(clk->hw, clk->new_rate,\n" - "> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240clk->parent->rate);\n" + "> ? ? ? if (clk->ops->set_rate)\n" + "> ? ? ? ? ? ? ? ?clk->ops->set_rate(clk->hw, clk->new_rate,\n" + "> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?clk->parent->rate);\n" ">\n" ">\n" - "> \302\240 \302\240 \302\240 \302\240if (clk->ops->recalc_rate)\n" - "> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240clk->rate = clk->ops->recalc_rate(clk->hw,\n" - "> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240clk->parent->rate);\n" - "> \302\240 \302\240 \302\240 \302\240else\n" - "> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240clk->rate = clk->parent->rate;\n" + "> ? ? ? ?if (clk->ops->recalc_rate)\n" + "> ? ? ? ? ? ? ? ?clk->rate = clk->ops->recalc_rate(clk->hw,\n" + "> ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?clk->parent->rate);\n" + "> ? ? ? ?else\n" + "> ? ? ? ? ? ? ? ?clk->rate = clk->parent->rate;\n" ">\n" "> I'm a bit confused. I thought recalc_rates was optional. But if I don't\n" "> implement it, the clocks rate will get set to parent's rate? Or is that a\n" @@ -90,12 +83,12 @@ "\n" "> Also, in clk_calc_new_rates(),\n" ">\n" - "> \302\240 \302\240 \302\240 \302\240if (!clk->ops->round_rate) {\n" - "> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240top = clk_calc_new_rates(clk->parent, rate);\n" - "> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240new_rate = clk->parent->new_rate;\n" + "> ? ? ? ?if (!clk->ops->round_rate) {\n" + "> ? ? ? ? ? ? ? ?top = clk_calc_new_rates(clk->parent, rate);\n" + "> ? ? ? ? ? ? ? ?new_rate = clk->parent->new_rate;\n" ">\n" - "> \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240goto out;\n" - "> \302\240 \302\240 \302\240 \302\240}\n" + "> ? ? ? ? ? ? ? ?goto out;\n" + "> ? ? ? ?}\n" ">\n" "> Is the code assuming that if there is no round rate ops that that clock node\n" "> is only a gating clock (as in, can't change frequency the input freq)? Just\n" @@ -122,4 +115,4 @@ "> Sent by an employee of the Qualcomm Innovation Center, Inc.\n" > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -07cb16367fa7cb67557be487cb83e6a22789163a54f7cbbe0ca9f092b5e3a777 +637236768af0ad9a433c5fea89458c4ee996d4f9e63ed7ff37b87f38f1cc5439
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.