All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Mario Limonciello <mario_limonciello@dell.com>
Cc: Kamal Mostafa <kamal@canonical.com>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dell-laptop: rfkill blacklist Dell XPS 13z, 15z
Date: Mon, 14 May 2012 22:55:33 +0100	[thread overview]
Message-ID: <20120514215533.GA10378@srcf.ucam.org> (raw)
In-Reply-To: <4FB17DA8.1040808@dell.com>

On Mon, May 14, 2012 at 04:48:24PM -0500, Mario Limonciello wrote:

> The problems were exposed on newer XPS laptops because those platforms 
> were not tested during platform development.  There really isn't a 
> scalable way to represent whether a platform was or wasn't tested 
> during development.  In a lot of situation things just work.  I would 
> like to do the right thing for the users with what information and 
> resources are available right now to put them in a better state.  An 
> aggressive approach of not taking patches to cover a broken interface 
> won't fix the problem of not testing machines already in the market, 
> it will just put end users of the kernel module at a disadvantage.

That's why it's better to just remove the interface. Providing a feature 
when we know it's broken on some unknown subset of hardware doesn't 
benefit anyone. If even Dell don't have any idea which set of machines 
it works on then how are we ever expected to make sure it's correct?

> 1) Don't blacklist any Latitude or Vostro.  These are tested during platform development.
> 2) Leave those compal_laptop supported ones blacklisted.
> 3) Blacklist 2010-2012 XPS.  These are currently not tested during platform development.
> 4) If problems start to show up on Inspiron, blacklist them invidually.  These platforms are currently tested during platform development though, so hopefully issues don't crop up.

Is this the set of criteria that the Windows tools use? If so, I'll 
implement it. If not, then either provide the set of criteria that the 
Windows tools use or I'll remove the interface.
-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2012-05-14 21:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-14 19:27 [PATCH] dell-laptop: rfkill blacklist Dell XPS 13z, 15z Kamal Mostafa
2012-05-14 19:37 ` Matthew Garrett
2012-05-14 20:00   ` Kamal Mostafa
2012-05-14 20:08   ` Mario Limonciello
2012-05-14 21:19     ` Matthew Garrett
2012-05-14 21:21       ` Mario Limonciello
2012-05-14 21:28         ` Matthew Garrett
2012-05-14 21:48           ` Mario Limonciello
2012-05-14 21:55             ` Matthew Garrett [this message]
2012-05-14 22:10               ` Jean-Louis Dupond
2012-05-15 15:05                 ` Martin Mokrejs
2012-05-14 20:02 ` Martin Mokrejs
2012-05-14 20:03 ` [PATCH v2] dell-laptop: rfkill blacklist Dell XPS 13z, 15 Kamal Mostafa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120514215533.GA10378@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=kamal@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.