From: Evgeniy Polyakov <zbr@ioremap.net>
To: NeilBrown <neilb@suse.de>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] w1: Introduce a slave mutex for serializing IO.
Date: Tue, 15 May 2012 05:26:34 +0400 [thread overview]
Message-ID: <20120515012634.GF25482@ioremap.net> (raw)
In-Reply-To: <20120509114349.5ceee472@notabene.brown>
On Wed, May 09, 2012 at 11:43:49AM +1000, NeilBrown (neilb@suse.de) wrote:
> However lockdep didn't like it. There are ordering problems between this
> mutex and and sysfs's s_active.
>
> When you access battery properies via sysfs, the sysfs lock is taken first,
> then the master->mutex.
> When w1_reconnect_slaves calls through to device_del and sys_addrm_finish,
> the mutex is held while the sysfs lock is wanted.
I only came to idea of not allowing sysfs in ->probe() and instead
introduce new callback, which will initialize 'external' to w1 core
parts without holding master's mutex
--
Evgeniy Polyakov
next prev parent reply other threads:[~2012-05-15 1:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 2:49 [PATCH] w1: Introduce a slave mutex for serializing IO NeilBrown
2012-05-01 21:39 ` Evgeniy Polyakov
2012-05-02 6:26 ` NeilBrown
2012-05-03 17:58 ` Evgeniy Polyakov
2012-05-03 21:08 ` NeilBrown
2012-05-03 21:27 ` Evgeniy Polyakov
2012-05-09 1:43 ` NeilBrown
2012-05-15 1:26 ` Evgeniy Polyakov [this message]
2012-05-18 6:05 ` NeilBrown
2012-06-10 20:58 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515012634.GF25482@ioremap.net \
--to=zbr@ioremap.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.