From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>,
linux-kernel@vger.kernel.org,
Lucas Meneghel Rodrigues <lmr@redhat.com>
Subject: Re: [PATCH] perf-record: Create events initially disabled -- again
Date: Mon, 14 May 2012 22:46:33 -0300 [thread overview]
Message-ID: <20120515014633.GD4254@infradead.org> (raw)
In-Reply-To: <4FB1B486.4020509@gmail.com>
Em Mon, May 14, 2012 at 07:42:30PM -0600, David Ahern escreveu:
> On 5/14/12 7:07 PM, Namhyung Kim wrote:
> >>Something else is wrong then. I tested that command (saw your patch in
> >>the history) and it worked for me. Also, this code path does not
> >>affect perf-stat -- it touches perf-record and perf-test only.
> >Ah, right. But still wouldn't it be better changing the conditional
> >rather than disabling it unconditionally?
> I think it would be best to disable all events initially and then
> enable them when ready. It works for perf-record and perf-test just
> fine and limits the samples to what you care about.
And we need to have all this logic in a central place, the "open" method
of perf_evlist :-)
The perf_target abstraction is the way to get there, but in the process
I think we really need to have each new method with a 'perf test' entry
and in addition to that an 'autotest'* entry to test the perf builtins.
- Arnaldo
* http://autotest.github.com/
next prev parent reply other threads:[~2012-05-15 1:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 4:01 [PATCH] perf-record: Create events initially disabled -- again David Ahern
2012-05-14 7:40 ` Namhyung Kim
2012-05-14 13:09 ` David Ahern
2012-05-14 14:21 ` David Ahern
2012-05-14 14:54 ` Arnaldo Carvalho de Melo
2012-05-15 1:52 ` David Ahern
2012-05-15 3:28 ` David Ahern
2012-05-15 3:46 ` Arnaldo Carvalho de Melo
2012-05-15 4:28 ` Namhyung Kim
2012-05-15 1:07 ` Namhyung Kim
2012-05-15 1:42 ` David Ahern
2012-05-15 1:46 ` Arnaldo Carvalho de Melo [this message]
2012-05-15 1:54 ` Namhyung Kim
2012-05-15 1:54 ` David Ahern
2012-05-15 3:22 ` Lucas Meneghel Rodrigues
2012-05-14 13:48 ` Arnaldo Carvalho de Melo
2012-05-21 7:41 ` [tip:perf/core] perf evsel: " tip-bot for David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515014633.GD4254@infradead.org \
--to=acme@ghostprotocols.net \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lmr@redhat.com \
--cc=namhyung.kim@lge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.