From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com,
matt.fleming@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86-64: use EFI to deal with platform wall clock
Date: Tue, 15 May 2012 13:47:07 +0100 [thread overview]
Message-ID: <20120515124707.GB25248@srcf.ucam.org> (raw)
In-Reply-To: <4FB265AB0200007800083CC5@nat28.tlf.novell.com>
On Tue, May 15, 2012 at 01:18:19PM +0100, Jan Beulich wrote:
> Simply removing the #ifdef around the respective code isn't enough,
> however: The runtime code must not only be forced to be executable, it
> also must have a proper virtual address set (which on at least the
> system I'm testing on isn't the case for all necessary regions, or at
> least not as early as they're now being required).
I don't understand this. The get_time pointer won't be updated to the
virtual function until the end of efi_enter_virtual_mode, at which point
all runtime regions should have a virtual address mapped. We also call
runtime_code_page_mkexec() immediately after updating that pointer,
although maybe the order should be swapped. So I think the bug you're
fixing is not the bug you think you're fixing...
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2012-05-15 12:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 12:18 [PATCH] x86-64: use EFI to deal with platform wall clock Jan Beulich
2012-05-15 12:47 ` Matthew Garrett [this message]
2012-05-15 13:19 ` Jan Beulich
2012-05-15 13:20 ` Matthew Garrett
2012-05-16 12:18 ` Jan Beulich
2012-05-16 12:39 ` Matthew Garrett
2012-05-16 12:59 ` Jan Beulich
2012-05-16 13:07 ` Matthew Garrett
2012-05-17 8:31 ` Matt Fleming
2012-05-25 15:00 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2012-05-25 15:20 Jan Beulich
2012-05-25 15:24 ` Matthew Garrett
2012-05-25 15:30 ` Jan Beulich
2012-05-25 15:34 ` Matthew Garrett
2012-06-06 9:47 ` Ingo Molnar
2012-05-26 10:26 ` Matt Fleming
2012-06-04 8:11 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515124707.GB25248@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=JBeulich@suse.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@linux.intel.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.