From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Date: Tue, 15 May 2012 08:12:10 -0700 Message-ID: <20120515151210.GB6119@google.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> <20120514181556.GE2366@google.com> <20120514183219.GG2366@google.com> <4FB1AD0A.50901@jp.fujitsu.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=zDR6xYe4950K90i/oCx/MCvNvshvp0pBvLgb7NZDRXM=; b=BExjyiyRGc4c04cylwVdt3c+MFbN6G+tWacYIIks4ActeLqfMpCf1SEc/ukhPV8UUW qBtR37RSxCIFrBmJIhJuNyRDn2O3/d2eyU/T1FO1oMNG2A4zvLJdyLj0yg7qqVpNrXsV srSQ8lICaXznrqA8NO2iDem9AMfat/zWCROITP+EuzTMYqmby5apF0EEhD5VeXldBvVR nqGQXAdYgJdNTEO6mSEnsL3JtahrK6WvPcQF0ehOmtuCCrgTOWPIjQ3Gvk1ypvDoTT5P hcPKNnSx9cdxWpTTp5oERhnbdVTEzt5rbLAfu7eipkH8PVoc3P5/t2awfxHC0lckyKIh jlsQ== Content-Disposition: inline In-Reply-To: <4FB1AD0A.50901@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel On Tue, May 15, 2012 at 10:10:34AM +0900, KAMEZAWA Hiroyuki wrote: > (2012/05/15 3:32), Tejun Heo wrote: > > > On Mon, May 14, 2012 at 11:15:56AM -0700, Tejun Heo wrote: > >> On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote: > >>> - if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) > >>> + if (cgroup_task_count(cgroup) > >>> + || !list_empty(&cgroup->children)) { > >>> + ret = -EBUSY; > >>> goto out; > >> > >> Why break the line? It doesn't go over 80 col. > > > > Ooh, it does. Sorry, my bad. But still, isn't it more usual to leave > > the operator in the preceding line and align the start of the second > > line with the first? ie. > > > > if (cgroup_task_count(cgroup) || > > !list_empty(&cgroup->children)) { > > > > > How about this ? > == > From: KAMEZAWA Hiroyuki > Date: Fri, 27 Apr 2012 13:19:19 +0900 > Subject: [PATCH] memcg: fix error code in hugetlb_force_memcg_empty() > > Changelog: > - clean up. > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: KAMEZAWA Hiroyuki Heh, it was a nitpick anyway. Please feel free to add my reviewed-by for the whole series. Thank you! -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965154Ab2EOPM0 (ORCPT ); Tue, 15 May 2012 11:12:26 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:64672 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756047Ab2EOPMX (ORCPT ); Tue, 15 May 2012 11:12:23 -0400 Date: Tue, 15 May 2012 08:12:10 -0700 From: Tejun Heo To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Frederic Weisbecker , Han Ying , Glauber Costa , "Aneesh Kumar K.V" , Andrew Morton , Hiroyuki Kamezawa , Linux Kernel Subject: Re: [PATCH v3 1/6] memcg: fix error code in hugetlb_force_memcg_empty() Message-ID: <20120515151210.GB6119@google.com> References: <4FACDED0.3020400@jp.fujitsu.com> <4FACDFAE.5050808@jp.fujitsu.com> <20120514181556.GE2366@google.com> <20120514183219.GG2366@google.com> <4FB1AD0A.50901@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4FB1AD0A.50901@jp.fujitsu.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 15, 2012 at 10:10:34AM +0900, KAMEZAWA Hiroyuki wrote: > (2012/05/15 3:32), Tejun Heo wrote: > > > On Mon, May 14, 2012 at 11:15:56AM -0700, Tejun Heo wrote: > >> On Fri, May 11, 2012 at 06:45:18PM +0900, KAMEZAWA Hiroyuki wrote: > >>> - if (cgroup_task_count(cgroup) || !list_empty(&cgroup->children)) > >>> + if (cgroup_task_count(cgroup) > >>> + || !list_empty(&cgroup->children)) { > >>> + ret = -EBUSY; > >>> goto out; > >> > >> Why break the line? It doesn't go over 80 col. > > > > Ooh, it does. Sorry, my bad. But still, isn't it more usual to leave > > the operator in the preceding line and align the start of the second > > line with the first? ie. > > > > if (cgroup_task_count(cgroup) || > > !list_empty(&cgroup->children)) { > > > > > How about this ? > == > From: KAMEZAWA Hiroyuki > Date: Fri, 27 Apr 2012 13:19:19 +0900 > Subject: [PATCH] memcg: fix error code in hugetlb_force_memcg_empty() > > Changelog: > - clean up. > Reviewed-by: Aneesh Kumar K.V > Signed-off-by: KAMEZAWA Hiroyuki Heh, it was a nitpick anyway. Please feel free to add my reviewed-by for the whole series. Thank you! -- tejun