From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Graeme Gregory <gg@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org, sameo@linux.intel.com, lrg@ti.com,
b-cousson@ti.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH 3/4] REGULATOR: regulator driver for Palmas series chips
Date: Tue, 15 May 2012 19:11:32 +0100 [thread overview]
Message-ID: <20120515181101.GC19592@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4FB1F3DD.3060005@slimlogic.co.uk>
[-- Attachment #1: Type: text/plain, Size: 698 bytes --]
On Tue, May 15, 2012 at 03:12:45PM +0900, Graeme Gregory wrote:
> On 14/05/12 17:52, Mark Brown wrote:
> > On Mon, May 14, 2012 at 10:58:31AM +0900, Graeme Gregory wrote:
> >> +
> >> + palmas_ldo_write(pmic->palmas, palmas_regs_info[id].ctrl_addr, reg);
> > Could use the core regmap stuff for the LDOs too.
> Enable/Disable now use regmap but is_enabled cant as it reads from a
> different bitmask.
Yeah, I did notice that and actually meant to go back and say that
really your current is_enabled() ought to be get_status(). The former
is supposed to return what the driver request to the hardware is, the
latter is supposed to return what the physical status is. Not super
critical though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-15 18:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 1:58 [PATCH 0/4] Adding support for Palmas PMIC Graeme Gregory
2012-05-14 1:58 ` [PATCH 1/4] MFD: palmas PMIC device support Graeme Gregory
2012-05-14 8:28 ` Mark Brown
2012-05-14 10:26 ` Graeme Gregory
2012-05-14 10:33 ` Mark Brown
2012-05-14 1:58 ` [PATCH 2/4] MFD: palmas PMIC device support Kconfig Graeme Gregory
2012-05-14 1:58 ` [PATCH 3/4] REGULATOR: regulator driver for Palmas series chips Graeme Gregory
2012-05-14 8:52 ` Mark Brown
2012-05-15 6:12 ` Graeme Gregory
2012-05-15 18:11 ` Mark Brown [this message]
2012-05-14 1:58 ` [PATCH 4/4] REGULATOR: regulator for Palmas Kconfig Graeme Gregory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515181101.GC19592@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=b-cousson@ti.com \
--cc=gg@slimlogic.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.