From: Stephen Hemminger <shemminger@vyatta.com>
To: Joe Perches <joe@perches.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: ipv4 and ipv6: Convert printk(KERN_DEBUG to pr_debug
Date: Tue, 15 May 2012 18:35:36 -0700 [thread overview]
Message-ID: <20120515183536.2cac1e29@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1fd8285e798ec9b3817c790a67b2bb655ffc931b.1337126963.git.joe@perches.com>
On Tue, 15 May 2012 17:11:54 -0700
Joe Perches <joe@perches.com> wrote:
> Use the current debugging style and enable dynamic_debug.
>
> Signed-off-by: Joe Perches <joe@perches.com>
This changes the action of the system. By default:
printk(KERN_DEBUG "foo\n");
is enabled all the time and prints to log with debug level.
But your version
pr_debug("foo\n");
defaults to being dropped until the system is built with dynamic
debug, and that particular debug instance is enabled.
Since these are all useful, but low priority messages, not I
don't think disabling them by default is such a great idea now.
next prev parent reply other threads:[~2012-05-16 1:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 0:11 [PATCH net-next 0/2] net/ipv4 and net/ipv6 logging cleanups Joe Perches
2012-05-16 0:11 ` [PATCH net-next 1/2] net: ipv6: Standardize prefixes for message logging Joe Perches
2012-05-16 0:11 ` [PATCH net-next 2/2] net: ipv4 and ipv6: Convert printk(KERN_DEBUG to pr_debug Joe Perches
2012-05-16 1:35 ` Stephen Hemminger [this message]
2012-05-16 1:49 ` Joe Perches
2012-05-16 5:01 ` [PATCH net-next 0/2] net/ipv4 and net/ipv6 logging cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515183536.2cac1e29@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=joe@perches.com \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.