diff for duplicates of <20120515184149.4E6B93E080A@localhost> diff --git a/a/1.txt b/N1/1.txt index 1476f06..d11b98a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -10,20 +10,20 @@ On Tue, 15 May 2012 17:29:14 +0900, Kukjin Kim <kgene.kim@samsung.com> wrote: > > / { > > interrupt-parent = <&intc_level1>; > > -> > intc_level1: interrupt-controller@xxx { +> > intc_level1: interrupt-controller at xxx { > > interrupt-controller; > > #interrupt-cells = <3>; > > <rest of the properties here>; > > }; > > -> > intc_level2: interrupt-controller@yyy { +> > intc_level2: interrupt-controller at yyy { > > interrupt-controller; > > #interrupt-cells = <2>; > > <rest of the properties here>; > > }; > > }; > > -> > The interrupt parent lookup for interrupt-controller@yyy fails. It inherits +> > The interrupt parent lookup for interrupt-controller at yyy fails. It inherits > > the interrupt-parent property from the root node and the root node ('/') > > specifies a 'interrupt-parent' property which represents the default interrupt > > root controller. But, the property '#interrupt-cells' might not be specified @@ -38,15 +38,15 @@ Hmmm... I dont see the bug... From your description above, I see the following sequence. First iteration: - child = &ic@yyy; + child = &ic at yyy; cannot find "interrupt-parent" so take 'if' clause p = of_get_parent(child); (root) iteration continues because #interrupt-cells not found in 'p'(root) Second iteration: child = root; found "interrupt-parent", so take 'else' clause - p = of_find_node_by_phandle(); (ic@xxx) - iteration stops because #interrupt-cells is found in 'p'(ic@xxx) + p = of_find_node_by_phandle(); (ic at xxx) + iteration stops because #interrupt-cells is found in 'p'(ic at xxx) What am I missing in my admittedly short look at the code? diff --git a/a/content_digest b/N1/content_digest index e516cb6..3376704 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,10 @@ "ref\01335813270-13083-1-git-send-email-thomas.abraham@linaro.org\0" "ref\01335813270-13083-11-git-send-email-thomas.abraham@linaro.org\0" "ref\007f801cd3274$cfbe4200$6f3ac600$%kim@samsung.com\0" - "From\0Grant Likely <grant.likely@secretlab.ca>\0" - "Subject\0RE: [PATCH 10/20] of/irq: fix interrupt parent lookup procedure\0" + "From\0grant.likely@secretlab.ca (Grant Likely)\0" + "Subject\0[PATCH 10/20] of/irq: fix interrupt parent lookup procedure\0" "Date\0Tue, 15 May 2012 12:41:49 -0600\0" - "To\0Kukjin Kim <kgene.kim@samsung.com>" - 'Thomas Abraham' <thomas.abraham@linaro.org> - " linux-arm-kernel@lists.infradead.org\0" - "Cc\0linux-samsung-soc@vger.kernel.org" - " rob.herring@calxeda.com\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Tue, 15 May 2012 17:29:14 +0900, Kukjin Kim <kgene.kim@samsung.com> wrote:\n" @@ -23,20 +19,20 @@ "> > / {\n" "> > interrupt-parent = <&intc_level1>;\n" "> > \n" - "> > intc_level1: interrupt-controller@xxx {\n" + "> > intc_level1: interrupt-controller at xxx {\n" "> > interrupt-controller;\n" "> > #interrupt-cells = <3>;\n" "> > <rest of the properties here>;\n" "> > };\n" "> > \n" - "> > intc_level2: interrupt-controller@yyy {\n" + "> > intc_level2: interrupt-controller at yyy {\n" "> > interrupt-controller;\n" "> > #interrupt-cells = <2>;\n" "> > <rest of the properties here>;\n" "> > };\n" "> > };\n" "> > \n" - "> > The interrupt parent lookup for interrupt-controller@yyy fails. It inherits\n" + "> > The interrupt parent lookup for interrupt-controller at yyy fails. It inherits\n" "> > the interrupt-parent property from the root node and the root node ('/')\n" "> > specifies a 'interrupt-parent' property which represents the default interrupt\n" "> > root controller. But, the property '#interrupt-cells' might not be specified\n" @@ -51,15 +47,15 @@ "following sequence.\n" "\n" "First iteration:\n" - "\tchild = &ic@yyy;\n" + "\tchild = &ic at yyy;\n" "\tcannot find \"interrupt-parent\" so take 'if' clause\n" "\t\tp = of_get_parent(child); (root)\n" "\titeration continues because #interrupt-cells not found in 'p'(root)\n" "Second iteration:\n" "\tchild = root;\n" "\tfound \"interrupt-parent\", so take 'else' clause\n" - "\t\tp = of_find_node_by_phandle(); (ic@xxx)\n" - "\titeration stops because #interrupt-cells is found in 'p'(ic@xxx)\n" + "\t\tp = of_find_node_by_phandle(); (ic at xxx)\n" + "\titeration stops because #interrupt-cells is found in 'p'(ic at xxx)\n" "\n" "What am I missing in my admittedly short look at the code?\n" "\n" @@ -119,4 +115,4 @@ "Grant Likely, B.Sc, P.Eng.\n" Secret Lab Technologies, Ltd. -d6b3f6539e56185860a466424f3b4277598d1151995fab472ab150ff78d6fc2d +08d64646af09d856828a791abeb1f4a1ef2f03b74c434c8e24508a12ba7359ea
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.