From: Ben Myers <bpm@sgi.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: use s_umount sema in xfs_sync_worker
Date: Tue, 15 May 2012 14:06:54 -0500 [thread overview]
Message-ID: <20120515190654.GI16099@sgi.com> (raw)
In-Reply-To: <4FB2A0D6.3050409@sgi.com>
On Tue, May 15, 2012 at 01:30:46PM -0500, Mark Tinguely wrote:
> On 05/14/12 15:34, Ben Myers wrote:
>
> >Protect xfs_sync_worker by using the s_umount semaphore at the read level to
> >provide exclusion with unmount while work is progressing.
> >
>
> >- xfs_log_force(mp, 0);
> >+ if (down_read_trylock(&mp->m_super->s_umount)) {
>
> Okay, the s_umount has down_write() performed upon it when it is
> created and does not do a up_write until the filesystem mount is
> complete.
>
> This test is just like the one in grab_super_passive(). The if
> statements have to be separated to know to do the corresponding
> up_read().
>
> >+ if (!(mp->m_flags& XFS_MOUNT_RDONLY)) {
> ...
> >+ up_read(&mp->m_super->s_umount);
>
> Looks good.
>
> Reveiewed-by: Mark Tinguely <tinguely@sgi.com>
Thanks Mark. xfstests ran in a loop overnight and is still going, so I'm
satisfied.
Signed-off-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-05-15 19:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 17:43 BUG in xlog_get_lowest_lsn Ben Myers
2012-05-14 20:34 ` [PATCH] xfs: use s_umount sema in xfs_sync_worker Ben Myers
2012-05-15 18:30 ` Mark Tinguely
2012-05-15 19:06 ` Ben Myers [this message]
2012-05-16 1:56 ` Dave Chinner
2012-05-16 17:04 ` Ben Myers
2012-05-17 7:16 ` Dave Chinner
2012-05-23 9:02 ` Dave Chinner
2012-05-23 16:45 ` Ben Myers
2012-05-24 22:39 ` Ben Myers
2012-05-25 20:45 ` [PATCH] xfs: shutdown xfs_sync_worker before the log Ben Myers
2012-05-29 15:07 ` Ben Myers
2012-05-29 15:36 ` Brian Foster
2012-05-29 17:04 ` Ben Myers
2012-05-29 17:54 ` Brian Foster
2012-05-31 16:23 ` Mark Tinguely
2012-06-06 4:26 ` Dave Chinner
2012-06-11 20:45 ` Ben Myers
2012-06-11 21:11 ` Mark Tinguely
2012-06-11 23:36 ` Dave Chinner
2012-06-14 17:13 ` Mark Tinguely
2012-06-14 23:56 ` Dave Chinner
2012-06-20 7:44 ` Christoph Hellwig
2012-06-20 7:36 ` Christoph Hellwig
2012-06-20 17:18 ` Ben Myers
2012-06-20 22:59 ` Dave Chinner
2012-06-21 7:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515190654.GI16099@sgi.com \
--to=bpm@sgi.com \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.