From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated Date: Tue, 15 May 2012 21:58:01 +0200 Message-ID: <20120515195801.GE23254@lunn.ch> References: <1336657841-2306-1-git-send-email-shubhrajyoti@ti.com> <20120511032455.6BB853E04A6@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Linus Walleij , andrew-g2DYL2Zd6BY@public.gmane.org, Shubhrajyoti D , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Grant Likely Return-path: Content-Disposition: inline In-Reply-To: <20120511032455.6BB853E04A6@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Thu, May 10, 2012 at 09:24:55PM -0600, Grant Likely wrote: > On Thu, 10 May 2012 16:01:27 +0200, Linus Walleij wrote: > > On Thu, May 10, 2012 at 3:50 PM, Shubhrajyoti D wrote: > > > > > Currently the prepare/unprepare transfer are called unconditionally. > > > The assumption is that every driver using the spi core queue infrastructure > > > has to populate the prepare and unprepare functions. This encourages > > > drivers to populate empty functions to prevent crashing. > > > This patch prevents the call to prepare/unprepare if not populated. > > > > > > Cc: Linus Walleij > > > Signed-off-by: Shubhrajyoti D > > > > Great! > > Acked-by: Linus Walleij > > Applied, thanks (after fixing extra whitespace defect). Hi Grant Is this going to appear in linux-next soon? Can i depend on having this patch for 3.5? Thanks Andrew ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966637Ab2EOT6X (ORCPT ); Tue, 15 May 2012 15:58:23 -0400 Received: from londo.lunn.ch ([80.238.139.98]:38466 "EHLO londo.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965427Ab2EOT6W (ORCPT ); Tue, 15 May 2012 15:58:22 -0400 Date: Tue, 15 May 2012 21:58:01 +0200 From: Andrew Lunn To: Grant Likely Cc: Linus Walleij , Shubhrajyoti D , spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org, andrew@lunn.ch Subject: Re: [PATCH RFC] spi: Dont call prepare/unprepare transfer if not populated Message-ID: <20120515195801.GE23254@lunn.ch> References: <1336657841-2306-1-git-send-email-shubhrajyoti@ti.com> <20120511032455.6BB853E04A6@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120511032455.6BB853E04A6@localhost> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 10, 2012 at 09:24:55PM -0600, Grant Likely wrote: > On Thu, 10 May 2012 16:01:27 +0200, Linus Walleij wrote: > > On Thu, May 10, 2012 at 3:50 PM, Shubhrajyoti D wrote: > > > > > Currently the prepare/unprepare transfer are called unconditionally. > > > The assumption is that every driver using the spi core queue infrastructure > > > has to populate the prepare and unprepare functions. This encourages > > > drivers to populate empty functions to prevent crashing. > > > This patch prevents the call to prepare/unprepare if not populated. > > > > > > Cc: Linus Walleij > > > Signed-off-by: Shubhrajyoti D > > > > Great! > > Acked-by: Linus Walleij > > Applied, thanks (after fixing extra whitespace defect). Hi Grant Is this going to appear in linux-next soon? Can i depend on having this patch for 3.5? Thanks Andrew