From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] ccache: allow dynamic selection of cache directory
Date: Tue, 15 May 2012 20:28:03 +0200 [thread overview]
Message-ID: <20120515202803.0016103e@skate> (raw)
In-Reply-To: <4FA44012.8040008@mind.be>
Le Fri, 04 May 2012 22:46:10 +0200,
Arnout Vandecappelle <arnout@mind.be> a ?crit :
> On second review, a better implementation would be to replace the
> first sed by
>
> sed -i 's,getenv("CCACHE_DIR"),getenv("BUILDROOT_CACHE_DIR"),'
> $(@D)/ccache.c
Euh? Why wouldn't we use CCACHE_DIR directly? What's the need of
renaming this environment variable here?
For the record, when I did the rework of ccache, I did hardcode the
cache directory into the ccache binary because I had issues passing
CCACHE_DIR everywhere. But I was trying to pass it to every gcc
invocation, and not globally through an export in the Makefile.
In any case, I would definitely prefer a solution that doesn't use a
wrapper. With a wrapper we would have:
-> ccache wrapper
-> ccache
-> external toolchain wrapper
-> gcc
If we can avoid the additional level of wrapping, it'd be nice.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-05-15 18:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-06 18:47 [Buildroot] [PATCH v2] ccache: allow dynamic selection of cache directory Thomas De Schampheleire
2012-05-04 19:17 ` Thomas De Schampheleire
2012-05-04 20:46 ` Arnout Vandecappelle
2012-05-05 7:17 ` Thomas De Schampheleire
2012-05-15 18:13 ` Thomas De Schampheleire
2012-05-15 18:28 ` Thomas Petazzoni [this message]
2012-05-15 18:49 ` Thomas De Schampheleire
2012-05-15 18:57 ` Thomas Petazzoni
2012-05-15 19:23 ` Thomas De Schampheleire
2012-05-15 19:50 ` Thomas Petazzoni
2012-05-15 20:42 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120515202803.0016103e@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.