diff for duplicates of <20120516130800.GC26337@opensource.wolfsonmicro.com> diff --git a/a/1.txt b/N1/1.txt index 9d810c0..e259b21 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,10 +2,10 @@ On Tue, May 15, 2012 at 07:17:11PM +0530, Yadwinder Singh Brar wrote: > On Thu, May 10, 2012 at 12:17 AM, Mark Brown > > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote: -> >> + if (iodev->dev->of_node) { -> >> + ret = max77686_pmic_dt_parse_pdata(iodev, pdata); -> >> + if (ret) -> >> + return ret; +> >> + ? ? if (iodev->dev->of_node) { +> >> + ? ? ? ? ? ? ret = max77686_pmic_dt_parse_pdata(iodev, pdata); +> >> + ? ? ? ? ? ? if (ret) +> >> + ? ? ? ? ? ? ? ? ? ? return ret; > > This ought to use of_regulator_match(). @@ -19,12 +19,12 @@ things you find in the device tree. If you were unconditionally instantiating all the regulators then suddenly this becomes a lot neater. -> >> + rdev[i] = regulator_register(®ulators[id], max77686->dev, -> >> + pdata->regulators[i].initdata, -> >> + max77686, NULL); +> >> + ? ? ? ? ? ? rdev[i] = regulator_register(®ulators[id], max77686->dev, +> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?pdata->regulators[i].initdata, +> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?max77686, NULL); > > No, you should unconditionally register all regulators the device -> > physically has. This is useful for debug and simplifies the code. +> > physically has. ?This is useful for debug and simplifies the code. > If we have to use only 2 or 3 regulators on our board out off 36 or > lets take a case if our chip supports 50/100 regulators, I think i @@ -39,3 +39,10 @@ it. Having information about all the regulators also allows us to do things like power off any unused regulators which were left on after boot (eg, due to bootloader or the PMIC defaults). +-------------- next part -------------- +A non-text attachment was scrubbed... +Name: signature.asc +Type: application/pgp-signature +Size: 836 bytes +Desc: Digital signature +URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120516/19a52f25/attachment.sig> diff --git a/a/2.bin b/a/2.bin deleted file mode 100644 index acfb0c1..0000000 --- a/a/2.bin +++ /dev/null @@ -1,17 +0,0 @@ ------BEGIN PGP SIGNATURE----- -Version: GnuPG v1.4.12 (GNU/Linux) - -iQIcBAEBAgAGBQJPs6aoAAoJEBus8iNuMP3dAcAP/A5sos9nrV0wWChFeJwxE6a6 -2EYqgs3/QWzWIyijWja2zJHfeBbG0rDEJEw4Tkq4zsOEfHwvkJ4orlUFz1415zsG -nVWQtTwod5Q5cAQqGUCSNOGYLx5eerloCLGi7oYp48gcmZ9FwkVfImRauAbs5GAa -VvjFd2Awwx3QBooBlgKdHR9MmY5zPhZIMw0fLlUm3vQpFgTumyXyGSRc+JtBt2M0 -MvjkJ291/M4BiCdWVanmNQqGDl/dYR5fqIGzY4c4Z34BfhP73BisKdFN//s5qUPi -M/fY8misCoDmn5umVUDXB/qaLB5VzUTBHVojqDIHrffjhXsNtsARrA7TMVla0iUX -pOIXU1Wgjop9oml76y3sh8MRqOm+G0lfJBYcA+z4xFvrxlXACTvsjg/c3HPHqyAG -GwsBzHPpz88BKwwR2rQMOpiONARTPor8jMuG6hzfTWjhk0FRuEvY3SkQsdeh2um2 -v+z/5wEh7XFlG02HBMz5mqPBKFys5Z4R3HX8WuNVnV5BXucgZmoHlP00wL1DAtZY -Vdfo12WdE0ztrxaWhjtziCwQVliQUdmc1DDovZf1SCVUb4TsxrbbBsOQdNOgeA/z -AP4TSaCMPsMwTb7ymltOfcYHV8VZ0rH2lyitkjRMv17fYNjQ8km3MwMaIs9gW0SQ -JAYV1kj2O0ahw4xi9oCZ -=tfPH ------END PGP SIGNATURE----- diff --git a/a/2.hdr b/a/2.hdr deleted file mode 100644 index 3237378..0000000 --- a/a/2.hdr +++ /dev/null @@ -1,2 +0,0 @@ -Content-Type: application/pgp-signature; name="signature.asc" -Content-Description: Digital signature diff --git a/a/content_digest b/N1/content_digest index 9f25044..a52fba8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,24 +2,20 @@ "ref\01336580695-1184-3-git-send-email-yadi.brar@samsung.com\0" "ref\020120509184709.GC32037@sirena.org.uk\0" "ref\0CAKew6eVZuOUH8RHQbffCGX7i=6dM-qOJXojoKrOsM3V5ugEjHA@mail.gmail.com\0" - "From\0Mark Brown <broonie@opensource.wolfsonmicro.com>\0" - "Subject\0Re: [PATCH 2/2] regulator: Add support for MAX77686.\0" + "From\0broonie@opensource.wolfsonmicro.com (Mark Brown)\0" + "Subject\0[PATCH 2/2] regulator: Add support for MAX77686.\0" "Date\0Wed, 16 May 2012 14:08:01 +0100\0" - "To\0Yadwinder Singh Brar <yadi.brar01@gmail.com>\0" - "Cc\0Yadwinder Singh <yadi.brar@samsung.com>" - linux-samsung-soc@vger.kernel.org - linux-kernel@vger.kernel.org - " linux-arm-kernel@lists.infradead.org\0" - "\01:1\0" + "To\0linux-arm-kernel@lists.infradead.org\0" + "\00:1\0" "b\0" "On Tue, May 15, 2012 at 07:17:11PM +0530, Yadwinder Singh Brar wrote:\n" "> On Thu, May 10, 2012 at 12:17 AM, Mark Brown\n" "> > On Wed, May 09, 2012 at 09:54:55PM +0530, Yadwinder Singh wrote:\n" "\n" - "> >> + \302\240 \302\240 if (iodev->dev->of_node) {\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 ret = max77686_pmic_dt_parse_pdata(iodev, pdata);\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 if (ret)\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 return ret;\n" + "> >> + ? ? if (iodev->dev->of_node) {\n" + "> >> + ? ? ? ? ? ? ret = max77686_pmic_dt_parse_pdata(iodev, pdata);\n" + "> >> + ? ? ? ? ? ? if (ret)\n" + "> >> + ? ? ? ? ? ? ? ? ? ? return ret;\n" "\n" "> > This ought to use of_regulator_match().\n" "\n" @@ -33,12 +29,12 @@ "instantiating all the regulators then suddenly this becomes a lot\n" "neater.\n" "\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 rdev[i] = regulator_register(®ulators[id], max77686->dev,\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240pdata->regulators[i].initdata,\n" - "> >> + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240max77686, NULL);\n" + "> >> + ? ? ? ? ? ? rdev[i] = regulator_register(®ulators[id], max77686->dev,\n" + "> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?pdata->regulators[i].initdata,\n" + "> >> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?max77686, NULL);\n" "\n" "> > No, you should unconditionally register all regulators the device\n" - "> > physically has. \302\240This is useful for debug and simplifies the code.\n" + "> > physically has. ?This is useful for debug and simplifies the code.\n" "\n" "> If we have to use only 2 or 3 regulators on our board out off 36 or\n" "> lets take a case if our chip supports 50/100 regulators, I think i\n" @@ -52,27 +48,13 @@ "\n" "Having information about all the regulators also allows us to do things\n" "like power off any unused regulators which were left on after boot (eg,\n" - due to bootloader or the PMIC defaults). - "\01:2\0" - "fn\0signature.asc\0" - "d\0Digital signature\0" - "b\0" - "-----BEGIN PGP SIGNATURE-----\n" - "Version: GnuPG v1.4.12 (GNU/Linux)\n" - "\n" - "iQIcBAEBAgAGBQJPs6aoAAoJEBus8iNuMP3dAcAP/A5sos9nrV0wWChFeJwxE6a6\n" - "2EYqgs3/QWzWIyijWja2zJHfeBbG0rDEJEw4Tkq4zsOEfHwvkJ4orlUFz1415zsG\n" - "nVWQtTwod5Q5cAQqGUCSNOGYLx5eerloCLGi7oYp48gcmZ9FwkVfImRauAbs5GAa\n" - "VvjFd2Awwx3QBooBlgKdHR9MmY5zPhZIMw0fLlUm3vQpFgTumyXyGSRc+JtBt2M0\n" - "MvjkJ291/M4BiCdWVanmNQqGDl/dYR5fqIGzY4c4Z34BfhP73BisKdFN//s5qUPi\n" - "M/fY8misCoDmn5umVUDXB/qaLB5VzUTBHVojqDIHrffjhXsNtsARrA7TMVla0iUX\n" - "pOIXU1Wgjop9oml76y3sh8MRqOm+G0lfJBYcA+z4xFvrxlXACTvsjg/c3HPHqyAG\n" - "GwsBzHPpz88BKwwR2rQMOpiONARTPor8jMuG6hzfTWjhk0FRuEvY3SkQsdeh2um2\n" - "v+z/5wEh7XFlG02HBMz5mqPBKFys5Z4R3HX8WuNVnV5BXucgZmoHlP00wL1DAtZY\n" - "Vdfo12WdE0ztrxaWhjtziCwQVliQUdmc1DDovZf1SCVUb4TsxrbbBsOQdNOgeA/z\n" - "AP4TSaCMPsMwTb7ymltOfcYHV8VZ0rH2lyitkjRMv17fYNjQ8km3MwMaIs9gW0SQ\n" - "JAYV1kj2O0ahw4xi9oCZ\n" - "=tfPH\n" - "-----END PGP SIGNATURE-----\n" + "due to bootloader or the PMIC defaults).\n" + "-------------- next part --------------\n" + "A non-text attachment was scrubbed...\n" + "Name: signature.asc\n" + "Type: application/pgp-signature\n" + "Size: 836 bytes\n" + "Desc: Digital signature\n" + URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120516/19a52f25/attachment.sig> -3880ace68697ba54b5548ad5cd63d8f52263089a6b173c7bea1f68f37c855011 +8b6a3890ece094725cf78584e80e49145d91ae4b2c694f73e14257e6ed939c07
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.